Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2629663003: Reland of Android: Delete rezip in favor of zipalign -p (Closed)

Created:
3 years, 11 months ago by agrieve
Modified:
3 years, 11 months ago
Reviewers:
michaelbai, jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 of Android: Delete rezip in favor of zipalign -p There's no need for a custom alignment tool now that zipalign supports page-aligning libraries. Previously revert in: https://codereview.chromium.org/2621353004/ Reason for reland: Updated merge script to not expect gdbserver BUG=676029, 676589 Review-Url: https://codereview.chromium.org/2629663003 Cr-Commit-Position: refs/heads/master@{#443886} Committed: https://chromium.googlesource.com/chromium/src/+/1bb2f878c384dc07a0aca0476a3e0d51e879b2eb

Patch Set 1 #

Patch Set 2 : no gdbserver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -597 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/tools/apk_merger.py View 1 5 chunks +4 lines, -8 lines 0 comments Download
M build/android/gyp/apkbuilder.py View 1 2 chunks +11 lines, -4 lines 0 comments Download
M build/android/gyp/finalize_apk.py View 1 5 chunks +30 lines, -93 lines 0 comments Download
D build/android/rezip/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
D build/android/rezip/RezipApk.java View 1 chunk +0 lines, -448 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 6 chunks +6 lines, -19 lines 0 comments Download
M build/config/android/rules.gni View 1 4 chunks +1 line, -13 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
agrieve
Created Reland of Android: Delete rezip in favor of zipalign -p
3 years, 11 months ago (2017-01-12 20:07:16 UTC) #1
agrieve
On 2017/01/12 20:07:16, agrieve wrote: > Created Reland of Android: Delete rezip in favor of ...
3 years, 11 months ago (2017-01-12 20:24:28 UTC) #3
michaelbai
lgtm
3 years, 11 months ago (2017-01-12 20:25:44 UTC) #4
jbudorick
rs lgtm
3 years, 11 months ago (2017-01-12 20:27:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629663003/200001
3 years, 11 months ago (2017-01-13 12:59:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/363671)
3 years, 11 months ago (2017-01-13 15:15:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629663003/200001
3 years, 11 months ago (2017-01-16 12:53:34 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 13:50:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/1bb2f878c384dc07a0aca0476a3e...

Powered by Google App Engine
This is Rietveld 408576698