Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2621353004: Revert of Android: Delete rezip in favor of zipalign -p (Closed)

Created:
3 years, 11 months ago by agrieve
Modified:
3 years, 11 months ago
Reviewers:
michaelbai, jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Delete rezip in favor of zipalign -p (patchset #2 id:210001 of https://codereview.chromium.org/2612773005/ ) Reason for revert: Broke system webview merging of debug builds. Original issue's description: > Reland of Android: Delete rezip in favor of zipalign -p > > There's no need for a custom alignment tool now that zipalign supports > page-aligning libraries. > > Previously reverted in: > https://codereview.chromium.org/2595233003/ > > Reason for reland: > Contains fix for monochrome (tested merging locally). > > BUG=676029, 676589 > > Review-Url: https://codereview.chromium.org/2612773005 > Cr-Commit-Position: refs/heads/master@{#442906} > Committed: https://chromium.googlesource.com/chromium/src/+/c3fd406f53369c1714d3587087146ff6ead4adab TBR=michaelbai@chromium.org,jbudorick@chromium.org NOTRY=true BUG=676029, 676589 Review-Url: https://codereview.chromium.org/2621353004 Cr-Commit-Position: refs/heads/master@{#443333} Committed: https://chromium.googlesource.com/chromium/src/+/3e55ac6b50a01574b61226ca47ca32211d81154f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -51 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/tools/apk_merger.py View 4 chunks +6 lines, -4 lines 0 comments Download
M build/android/gyp/apkbuilder.py View 2 chunks +5 lines, -12 lines 0 comments Download
M build/android/gyp/finalize_apk.py View 5 chunks +91 lines, -28 lines 0 comments Download
A build/android/rezip/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A build/android/rezip/RezipApk.java View 1 chunk +448 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 6 chunks +19 lines, -6 lines 0 comments Download
M build/config/android/rules.gni View 4 chunks +13 lines, -1 line 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
agrieve
Created Revert of Android: Delete rezip in favor of zipalign -p
3 years, 11 months ago (2017-01-12 16:53:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621353004/1
3 years, 11 months ago (2017-01-12 16:54:31 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/367822)
3 years, 11 months ago (2017-01-12 18:08:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621353004/1
3 years, 11 months ago (2017-01-12 19:53:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3e55ac6b50a01574b61226ca47ca32211d81154f
3 years, 11 months ago (2017-01-12 19:59:55 UTC) #13
agrieve
3 years, 11 months ago (2017-01-12 20:07:15 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2629663003/ by agrieve@chromium.org.

The reason for reverting is: will update in a moment.

Powered by Google App Engine
This is Rietveld 408576698