Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 2612773005: Reland of Android: Delete rezip in favor of zipalign -p (Closed)

Created:
3 years, 11 months ago by agrieve
Modified:
3 years, 11 months ago
Reviewers:
michaelbai, jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Android: Delete rezip in favor of zipalign -p There's no need for a custom alignment tool now that zipalign supports page-aligning libraries. Previously reverted in: https://codereview.chromium.org/2595233003/ Reason for reland: Contains fix for monochrome (tested merging locally). BUG=676029, 676589 Review-Url: https://codereview.chromium.org/2612773005 Cr-Commit-Position: refs/heads/master@{#442906} Committed: https://chromium.googlesource.com/chromium/src/+/c3fd406f53369c1714d3587087146ff6ead4adab

Patch Set 1 #

Patch Set 2 : don't do crazy. prefix renaming when crazy linker is not used (monochrome) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -595 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/tools/apk_merger.py View 1 4 chunks +4 lines, -6 lines 0 comments Download
M build/android/gyp/apkbuilder.py View 1 2 chunks +11 lines, -4 lines 0 comments Download
M build/android/gyp/finalize_apk.py View 1 5 chunks +30 lines, -93 lines 0 comments Download
D build/android/rezip/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
D build/android/rezip/RezipApk.java View 1 chunk +0 lines, -448 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 6 chunks +6 lines, -19 lines 0 comments Download
M build/config/android/rules.gni View 1 4 chunks +1 line, -13 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
agrieve
Created Reland of Android: Delete rezip in favor of zipalign -p
3 years, 11 months ago (2017-01-06 02:51:49 UTC) #1
agrieve
On 2017/01/06 02:51:49, agrieve wrote: > Created Reland of Android: Delete rezip in favor of ...
3 years, 11 months ago (2017-01-06 02:55:19 UTC) #3
michaelbai
lgtm
3 years, 11 months ago (2017-01-11 01:13:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612773005/210001
3 years, 11 months ago (2017-01-11 15:09:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:210001) as https://chromium.googlesource.com/chromium/src/+/c3fd406f53369c1714d3587087146ff6ead4adab
3 years, 11 months ago (2017-01-11 15:14:14 UTC) #13
agrieve
3 years, 11 months ago (2017-01-12 16:53:45 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:210001) has been created in
https://codereview.chromium.org/2621353004/ by agrieve@chromium.org.

The reason for reverting is: Broke system webview merging of debug builds..

Powered by Google App Engine
This is Rietveld 408576698