Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: src/property-details.h

Issue 2629423002: [runtime] Remove PropertyType definition and use PropertyKind/PropertyLocation instead. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/property-details.h
diff --git a/src/property-details.h b/src/property-details.h
index 02354b89babc79616f0733b944b4ec3ca3f14e25..d616ae76e164c1768d8cd35b2ae7a4603e760f27 100644
--- a/src/property-details.h
+++ b/src/property-details.h
@@ -72,18 +72,6 @@ enum PropertyKind { kData = 0, kAccessor = 1 };
// Must fit in the BitField PropertyDetails::LocationField.
enum PropertyLocation { kField = 0, kDescriptor = 1 };
-
-// Order of properties is significant.
-// Must fit in the BitField PropertyDetails::TypeField.
-// A copy of this is in debug/mirrors.js.
-enum PropertyType {
- DATA = (kField << 1) | kData,
- DATA_CONSTANT = (kDescriptor << 1) | kData,
- ACCESSOR = (kField << 1) | kAccessor,
- ACCESSOR_CONSTANT = (kDescriptor << 1) | kAccessor
-};
-
-
class Representation {
public:
enum Kind {
@@ -298,8 +286,6 @@ class PropertyDetails BASE_EMBEDDED {
PropertyKind kind() const { return KindField::decode(value_); }
PropertyLocation location() const { return LocationField::decode(value_); }
- PropertyType type() const { return TypeField::decode(value_); }
-
PropertyAttributes attributes() const {
return AttributesField::decode(value_);
}
@@ -348,12 +334,6 @@ class PropertyDetails BASE_EMBEDDED {
: public BitField<uint32_t, 9 + kDescriptorIndexBitCount,
kDescriptorIndexBitCount> {}; // NOLINT
- // NOTE: TypeField overlaps with KindField and LocationField.
- class TypeField : public BitField<PropertyType, 0, 2> {};
- STATIC_ASSERT(KindField::kNext == LocationField::kShift);
- STATIC_ASSERT(TypeField::kShift == KindField::kShift);
- STATIC_ASSERT(TypeField::kNext == LocationField::kNext);
-
// All bits for both fast and slow objects must fit in a smi.
STATIC_ASSERT(DictionaryStorageField::kNext <= 31);
STATIC_ASSERT(FieldIndexField::kNext <= 31);
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698