Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2629323002: Remove Chromium's custom closure runner. (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Chromium's custom closure runner. Our ChromePass and ChromeCodingConvention have been properly upstreamed into Closure's compiler.jar itself! Huzzah! java -jar compiler.jar --chrome_pass # is roughly equivalent TBR=tbreisacher@chromium.org BUG=421562 Review-Url: https://codereview.chromium.org/2629323002 . Cr-Commit-Position: refs/heads/master@{#445661} Committed: https://chromium.googlesource.com/chromium/src/+/3c7fb5c03c58df7af384324a84a4645ca57944c1

Patch Set 1 : checks_only #

Patch Set 2 : newer #

Patch Set 3 : checks_only issues #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1632 lines) Patch
M third_party/closure_compiler/README.chromium View 1 2 chunks +2 lines, -11 lines 0 comments Download
D third_party/closure_compiler/build_and_run_tests View 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/closure_compiler/closure_args.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/closure_compiler/closure_args.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compile.py View 11 chunks +7 lines, -22 lines 0 comments Download
M third_party/closure_compiler/compile2.py View 7 chunks +5 lines, -15 lines 0 comments Download
M third_party/closure_compiler/compile_js.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/closure_compiler/compile_js2.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/closure_compiler/compiler/compiler.jar View 1 Binary file 0 comments Download
M third_party/closure_compiler/compiler_test.py View 1 2 4 chunks +9 lines, -8 lines 0 comments Download
M third_party/closure_compiler/externs/chrome_extensions.js View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/closure_compiler/externs/polymer-1.0.js View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/closure_compiler/roll_closure_compiler View 2 chunks +6 lines, -11 lines 0 comments Download
M third_party/closure_compiler/run_compiler View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/closure_compiler/runner/build_runner_jar.py View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/closure_compiler/runner/how_to_test_compiler_pass.md View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/closure_compiler/runner/runner.jar View Binary file 0 comments Download
D third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java View 1 chunk +0 lines, -456 lines 0 comments Download
D third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePassConfig.java View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/closure_compiler/runner/src/org/chromium/closure/compiler/Runner.java View 1 chunk +0 lines, -292 lines 0 comments Download
D third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java View 1 chunk +0 lines, -543 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dan Beam
3 years, 11 months ago (2017-01-13 03:36:18 UTC) #3
Tyler Breisacher (Chromium)
If you wait until cl/144411180 is pushed externally then your jar size will remain small. ...
3 years, 11 months ago (2017-01-13 19:58:33 UTC) #4
Dan Beam
On 2017/01/13 19:58:33, Tyler Breisacher (Chromium) wrote: > If you wait until cl/144411180 is pushed ...
3 years, 11 months ago (2017-01-14 01:32:57 UTC) #5
Dan Beam
ping
3 years, 11 months ago (2017-01-24 05:34:46 UTC) #6
Dan Beam
TBR=tbreisacher@ as he was OK with this over chat
3 years, 11 months ago (2017-01-24 05:53:44 UTC) #8
Dan Beam
Committed patchset #4 (id:100001) manually as 3c7fb5c03c58df7af384324a84a4645ca57944c1 (presubmit successful).
3 years, 11 months ago (2017-01-24 05:55:28 UTC) #10
tbreisacher
3 years, 11 months ago (2017-01-24 17:16:17 UTC) #12
Message was sent while issue was closed.
lgtm. There should be a release going out in the next couple days, at which
point you can try switching to the js version of the compiler. We might need to
add a bunch of flags to it that exist in the Java version but not the JS one.

Powered by Google App Engine
This is Rietveld 408576698