Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java

Issue 2629323002: Remove Chromium's custom closure runner. (Closed)
Patch Set: merge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java
diff --git a/third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java b/third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java
deleted file mode 100644
index 3417e44fe4943d1b3aaa946885c4e674bdc93c8b..0000000000000000000000000000000000000000
--- a/third_party/closure_compiler/runner/src/org/chromium/closure/compiler/ChromeCodingConvention.java
+++ /dev/null
@@ -1,76 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.closure.compiler;
-
-import com.google.common.collect.ImmutableList;
-import com.google.common.collect.ImmutableSet;
-import com.google.common.collect.Sets;
-import com.google.javascript.jscomp.ClosureCodingConvention.AssertInstanceofSpec;
-import com.google.javascript.jscomp.CodingConvention;
-import com.google.javascript.jscomp.CodingConventions;
-import com.google.javascript.rhino.jstype.FunctionType;
-import com.google.javascript.rhino.jstype.ObjectType;
-import com.google.javascript.rhino.Node;
-
-import java.util.Collection;
-import java.util.Set;
-
-public class ChromeCodingConvention extends CodingConventions.Proxy {
-
- private final Set<String> indirectlyDeclaredProperties;
-
- public ChromeCodingConvention() {
- this(CodingConventions.getDefault());
- }
-
- public ChromeCodingConvention(CodingConvention wrapped) {
- super(wrapped);
-
- Set<String> props = Sets.newHashSet("instance_", "getInstance");
- props.addAll(wrapped.getIndirectlyDeclaredProperties());
- indirectlyDeclaredProperties = ImmutableSet.copyOf(props);
- }
-
- @Override
- public String getSingletonGetterClassName(Node callNode) {
- Node callArg = callNode.getFirstChild();
-
- if (!callArg.matchesQualifiedName("cr.addSingletonGetter") ||
- callNode.getChildCount() != 2) {
- return super.getSingletonGetterClassName(callNode);
- }
-
- return callArg.getNext().getQualifiedName();
- }
-
- @Override
- public void applySingletonGetterOld(FunctionType functionType,
- FunctionType getterType, ObjectType objectType) {
- super.applySingletonGetterOld(functionType, getterType, objectType);
- functionType.defineDeclaredProperty("getInstance", getterType,
- functionType.getSource());
- functionType.defineDeclaredProperty("instance_", objectType,
- functionType.getSource());
- }
-
- @Override
- public Collection<String> getIndirectlyDeclaredProperties() {
- return indirectlyDeclaredProperties;
- }
-
- @Override
- public Collection<AssertionFunctionSpec> getAssertionFunctions() {
- return ImmutableList.of(
- new AssertionFunctionSpec("assert"),
- new AssertInstanceofSpec("cr.ui.decorate")
- );
- }
-
- @Override
- public boolean isFunctionCallThatAlwaysThrows(Node n) {
- return CodingConventions.defaultIsFunctionCallThatAlwaysThrows(
- n, "assertNotReached");
- }
-}

Powered by Google App Engine
This is Rietveld 408576698