Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: third_party/closure_compiler/externs/chrome_extensions.js

Issue 2629323002: Remove Chromium's custom closure runner. (Closed)
Patch Set: merge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/closure_compiler/compiler_test.py ('k') | third_party/closure_compiler/externs/polymer-1.0.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/closure_compiler/externs/chrome_extensions.js
diff --git a/third_party/closure_compiler/externs/chrome_extensions.js b/third_party/closure_compiler/externs/chrome_extensions.js
index 1c4e6f111f5779a51bc9a236c74acffbeea9a294..ac0cd611d8bf415497619f6ffd31f839b6897000 100644
--- a/third_party/closure_compiler/externs/chrome_extensions.js
+++ b/third_party/closure_compiler/externs/chrome_extensions.js
@@ -49,7 +49,7 @@
* The best practices for each are described in more detail below. It
* should be noted that, due to historical reasons, and the evolutionary
* nature of this file, much this file currently violates the best practices
- * described below. As changed are made, the changes should adhere to the
+ * described below. As changes are made, the changes should adhere to the
* best practices.
*
* A. When to Add Packages to this File?
@@ -126,7 +126,7 @@
* Always qualify the type name to reduce top-level pollution in this file:
*
* Do:
- * chrome.extension.Port = function() {}
+ * chrome.runtime.Port = function() {}
* Don't:
* function Port() {}
*
@@ -6589,7 +6589,6 @@ function Debuggee() {}
Debuggee.prototype.tabId;
-
/**
* @see https://developer.chrome.com/extensions/contentSettings.html#type-ResourceIdentifier
* @constructor
« no previous file with comments | « third_party/closure_compiler/compiler_test.py ('k') | third_party/closure_compiler/externs/polymer-1.0.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698