Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2629193002: Remove skia::PlatformDevice (Closed)

Created:
3 years, 11 months ago by f(malita)
Modified:
3 years, 11 months ago
Reviewers:
robertphillips, reed1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : also remove SK_SUPPORT_LEGACY_GETTOPDEVICE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -103 lines) Patch
M skia/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M skia/ext/platform_canvas.cc View 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D skia/ext/platform_device.h View 1 chunk +0 lines, -61 lines 0 comments Download
D skia/ext/platform_device.cc View 1 chunk +0 lines, -36 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
f(malita)
Depends on http://crrev.com/2629523004.
3 years, 11 months ago (2017-01-12 19:25:21 UTC) #2
reed1
lgtm
3 years, 11 months ago (2017-01-12 19:27:23 UTC) #3
f(malita)
On 2017/01/12 19:27:23, reed1 wrote: > lgtm While at it, we can also zap SK_SUPPORT_LEGACY_GETTOPDEVICE!
3 years, 11 months ago (2017-01-12 20:38:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629193002/20001
3 years, 11 months ago (2017-01-13 14:07:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629193002/20001
3 years, 11 months ago (2017-01-13 17:11:08 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 17:21:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5fa6332176e79da76fd8c513eead...

Powered by Google App Engine
This is Rietveld 408576698