use SkRasterHandleAllocator to support GDI drawing in SkCanvas

use SkRasterHandleAllocator to support GDI drawing in SkCanvas

This is a new mechanism, replacing the previous technique of subclassing
SkDevice.

BUG=675977
Review-Url: https://codereview.chromium.org/2629523004
Cr-Commit-Position: refs/heads/master@{#443365}
Committed: https://chromium.googlesource.com/chromium/src/+/ae7d8e56c8cc244b4ca0ae692b76e662c2563329

[reed1, 2017-01-12 14:33:39]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 14:34:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2017-01-12 14:34:11]

reed@google.com changed reviewers:
+ bungeman@chromium.org, fmalita@chromium.org

[reed1, 2017-01-12 14:34:51]

Description was changed from

==========
use SkRasterHandleAllocator to support GDI drawing in SkCanvas

This is a new mechanism, replacing the previous technique of subclassing
SkDevice.

BUG=
==========

to

==========
use SkRasterHandleAllocator to support GDI drawing in SkCanvas

This is a new mechanism, replacing the previous technique of subclassing
SkDevice.

BUG=675977
==========

[f(malita), 2017-01-12 14:43:33]

lgtm

https://codereview.chromium.org/2629523004/diff/20001/skia/ext/raster_handle_...
File skia/ext/raster_handle_allocator_win.cc (right):

https://codereview.chromium.org/2629523004/diff/20001/skia/ext/raster_handle_...
skia/ext/raster_handle_allocator_win.cc:116:
std::unique_ptr<SkRasterHandleAllocator>(new GDIAllocator), info,
nit: skstd::make_unique, or maybe base::MakeUnique?

[bungeman-chromium, 2017-01-12 14:56:53]

lgtm

https://codereview.chromium.org/2629523004/diff/20001/skia/ext/raster_handle_...
File skia/ext/raster_handle_allocator_win.cc (right):

https://codereview.chromium.org/2629523004/diff/20001/skia/ext/raster_handle_...
skia/ext/raster_handle_allocator_win.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
nit: 2017?

[commit-bot: I haz the power, 2017-01-12 16:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 16:18:20]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[reed1, 2017-01-12 18:54:01]

https://codereview.chromium.org/2629523004/diff/20001/skia/ext/raster_handle_...
File skia/ext/raster_handle_allocator_win.cc (right):

https://codereview.chromium.org/2629523004/diff/20001/skia/ext/raster_handle_...
skia/ext/raster_handle_allocator_win.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
On 2017/01/12 14:56:53, bungeman-chromium wrote:
> nit: 2017?

Done.

https://codereview.chromium.org/2629523004/diff/20001/skia/ext/raster_handle_...
skia/ext/raster_handle_allocator_win.cc:116:
std::unique_ptr<SkRasterHandleAllocator>(new GDIAllocator), info,
On 2017/01/12 14:43:33, f(malita) wrote:
> nit: skstd::make_unique, or maybe base::MakeUnique?

Done.

[reed1, 2017-01-12 18:54:56]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 18:55:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-01-12 20:19:23]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2017-01-12 20:19:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
bungeman@chromium.org, fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/2629523004/#ps60001
(title: "remove printfs")

[commit-bot: I haz the power, 2017-01-12 20:20:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 21:28:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484252363367670,
"parent_rev": "e36f41845d3f6232aaeddf68fcde9576c7446344", "commit_rev":
"ae7d8e56c8cc244b4ca0ae692b76e662c2563329"}

[commit-bot: I haz the power, 2017-01-12 21:29:26]

Description was changed from

==========
use SkRasterHandleAllocator to support GDI drawing in SkCanvas

This is a new mechanism, replacing the previous technique of subclassing
SkDevice.

BUG=675977
==========

to

==========
use SkRasterHandleAllocator to support GDI drawing in SkCanvas

This is a new mechanism, replacing the previous technique of subclassing
SkDevice.

BUG=675977

Review-Url: https://codereview.chromium.org/2629523004
Cr-Commit-Position: refs/heads/master@{#443365}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae7d8e56c8cc244b4ca0ae692b76...
==========

[commit-bot: I haz the power, 2017-01-12 21:29:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ae7d8e56c8cc244b4ca0ae692b76...