Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2629113004: Revert of [runtime] Change JavaScriptFrame::GetFunctions interface. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [runtime] Change JavaScriptFrame::GetFunctions interface. (patchset #2 id:20001 of https://codereview.chromium.org/2626213002/ ) Reason for revert: Breaks compilation. Original issue's description: > [runtime] Change JavaScriptFrame::GetFunctions interface. > > This adapts the aformentioned interface to no longer return a list of > {JSFunction} objects, but {SharedFunctionInfo} objects instead. Since > deoptimization data only contains the latter as literals, this by now > represents the fast path. All call sites requiring the former can use > the slow path via {JavaScriptFrame::Summarize} instead. > > R=jarin@chromium.org > > Review-Url: https://codereview.chromium.org/2626213002 > Cr-Commit-Position: refs/heads/master@{#42311} > Committed: https://chromium.googlesource.com/v8/v8/+/25a9364f25a40986f4d7266b1fe53a5921754f6a TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2629113004 Cr-Commit-Position: refs/heads/master@{#42312} Committed: https://chromium.googlesource.com/v8/v8/+/dcddcc13831c061dee7258c9376f140dd50e04b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -36 lines) Patch
M src/accessors.cc View 3 chunks +18 lines, -15 lines 0 comments Download
M src/frames.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/frames.cc View 4 chunks +20 lines, -14 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Starzinger
Created Revert of [runtime] Change JavaScriptFrame::GetFunctions interface.
3 years, 11 months ago (2017-01-13 09:24:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629113004/1
3 years, 11 months ago (2017-01-13 09:24:54 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 09:25:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dcddcc13831c061dee7258c9376f140dd50...

Powered by Google App Engine
This is Rietveld 408576698