Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2626213002: [runtime] Change JavaScriptFrame::GetFunctions interface. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Change JavaScriptFrame::GetFunctions interface. This adapts the aformentioned interface to no longer return a list of {JSFunction} objects, but {SharedFunctionInfo} objects instead. Since deoptimization data only contains the latter as literals, this by now represents the fast path. All call sites requiring the former can use the slow path via {JavaScriptFrame::Summarize} instead. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2626213002 Cr-Original-Commit-Position: refs/heads/master@{#42311} Committed: https://chromium.googlesource.com/v8/v8/+/25a9364f25a40986f4d7266b1fe53a5921754f6a Review-Url: https://codereview.chromium.org/2626213002 Cr-Commit-Position: refs/heads/master@{#42314} Committed: https://chromium.googlesource.com/v8/v8/+/52d05e12188c21ccf1a30bafb1f545945dd28c3f

Patch Set 1 #

Patch Set 2 : Small fix. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -44 lines) Patch
M src/accessors.cc View 1 2 3 chunks +15 lines, -18 lines 0 comments Download
M src/frames.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/frames.cc View 1 2 4 chunks +13 lines, -19 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (17 generated)
Michael Starzinger
3 years, 11 months ago (2017-01-12 12:00:15 UTC) #3
Jarin
lgtm. Nice!
3 years, 11 months ago (2017-01-13 08:48:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626213002/20001
3 years, 11 months ago (2017-01-13 09:14:54 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/25a9364f25a40986f4d7266b1fe53a5921754f6a
3 years, 11 months ago (2017-01-13 09:16:37 UTC) #12
Michael Starzinger
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2629113004/ by mstarzinger@chromium.org. ...
3 years, 11 months ago (2017-01-13 09:24:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626213002/40001
3 years, 11 months ago (2017-01-13 10:27:35 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 10:29:19 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/52d05e12188c21ccf1a30bafb1f545945dd...

Powered by Google App Engine
This is Rietveld 408576698