Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: src/frames.h

Issue 2629113004: Revert of [runtime] Change JavaScriptFrame::GetFunctions interface. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/accessors.cc ('k') | src/frames.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_FRAMES_H_ 5 #ifndef V8_FRAMES_H_
6 #define V8_FRAMES_H_ 6 #define V8_FRAMES_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/handles.h" 9 #include "src/handles.h"
10 #include "src/safepoint-table.h" 10 #include "src/safepoint-table.h"
(...skipping 879 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 // Garbage collection support. 890 // Garbage collection support.
891 void Iterate(ObjectVisitor* v) const override; 891 void Iterate(ObjectVisitor* v) const override;
892 892
893 // Printing support. 893 // Printing support.
894 void Print(StringStream* accumulator, PrintMode mode, 894 void Print(StringStream* accumulator, PrintMode mode,
895 int index) const override; 895 int index) const override;
896 896
897 // Determine the code for the frame. 897 // Determine the code for the frame.
898 Code* unchecked_code() const override; 898 Code* unchecked_code() const override;
899 899
900 // Return a list with {SharedFunctionInfo} objects of this frame. 900 // Return a list with JSFunctions of this frame.
901 virtual void GetFunctions(List<SharedFunctionInfo*>* functions) const; 901 virtual void GetFunctions(List<JSFunction*>* functions) const;
902 902
903 // Lookup exception handler for current {pc}, returns -1 if none found. Also 903 // Lookup exception handler for current {pc}, returns -1 if none found. Also
904 // returns data associated with the handler site specific to the frame type: 904 // returns data associated with the handler site specific to the frame type:
905 // - OptimizedFrame : Data is the stack slot count of the entire frame. 905 // - OptimizedFrame : Data is the stack slot count of the entire frame.
906 // - InterpretedFrame: Data is the register index holding the context. 906 // - InterpretedFrame: Data is the register index holding the context.
907 virtual int LookupExceptionHandlerInTable( 907 virtual int LookupExceptionHandlerInTable(
908 int* data, HandlerTable::CatchPrediction* prediction); 908 int* data, HandlerTable::CatchPrediction* prediction);
909 909
910 // Architecture-specific register description. 910 // Architecture-specific register description.
911 static Register fp_register(); 911 static Register fp_register();
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
970 }; 970 };
971 971
972 972
973 class OptimizedFrame : public JavaScriptFrame { 973 class OptimizedFrame : public JavaScriptFrame {
974 public: 974 public:
975 Type type() const override { return OPTIMIZED; } 975 Type type() const override { return OPTIMIZED; }
976 976
977 // GC support. 977 // GC support.
978 void Iterate(ObjectVisitor* v) const override; 978 void Iterate(ObjectVisitor* v) const override;
979 979
980 // Return a list with {SharedFunctionInfo} objects of this frame. 980 // Return a list with JSFunctions of this frame.
981 // The functions are ordered bottom-to-top (i.e. functions.last() 981 // The functions are ordered bottom-to-top (i.e. functions.last()
982 // is the top-most activation) 982 // is the top-most activation)
983 void GetFunctions(List<SharedFunctionInfo*>* functions) const override; 983 void GetFunctions(List<JSFunction*>* functions) const override;
984 984
985 void Summarize( 985 void Summarize(
986 List<FrameSummary>* frames, 986 List<FrameSummary>* frames,
987 FrameSummary::Mode mode = FrameSummary::kExactSummary) const override; 987 FrameSummary::Mode mode = FrameSummary::kExactSummary) const override;
988 988
989 // Lookup exception handler for current {pc}, returns -1 if none found. 989 // Lookup exception handler for current {pc}, returns -1 if none found.
990 int LookupExceptionHandlerInTable( 990 int LookupExceptionHandlerInTable(
991 int* data, HandlerTable::CatchPrediction* prediction) override; 991 int* data, HandlerTable::CatchPrediction* prediction) override;
992 992
993 DeoptimizationInputData* GetDeoptimizationData(int* deopt_index) const; 993 DeoptimizationInputData* GetDeoptimizationData(int* deopt_index) const;
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
1423 1423
1424 1424
1425 // Reads all frames on the current stack and copies them into the current 1425 // Reads all frames on the current stack and copies them into the current
1426 // zone memory. 1426 // zone memory.
1427 Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone); 1427 Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone);
1428 1428
1429 } // namespace internal 1429 } // namespace internal
1430 } // namespace v8 1430 } // namespace v8
1431 1431
1432 #endif // V8_FRAMES_H_ 1432 #endif // V8_FRAMES_H_
OLDNEW
« no previous file with comments | « src/accessors.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698