Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2628973007: Migrate WTF::Vector::append() to ::push_back() in binding templates (Closed)

Created:
3 years, 11 months ago by pilgrim_google
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::append() to ::push_back() in binding templates As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/binding/templates/ which affects several generated V8 bindings (V8Document, V8Location, and V8Window). There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2628973007 Cr-Commit-Position: refs/heads/master@{#443759} Committed: https://chromium.googlesource.com/chromium/src/+/237a04c31ab855d78f777e907341dc520b2d2c71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 11 months ago (2017-01-13 17:59:02 UTC) #3
haraken
LGTM
3 years, 11 months ago (2017-01-14 01:03:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628973007/1
3 years, 11 months ago (2017-01-14 01:22:32 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 01:29:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/237a04c31ab855d78f777e907341...

Powered by Google App Engine
This is Rietveld 408576698