third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl - Issue 2628973007: Migrate WTF::Vector::append() to ::push_back() in binding templates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2628973007: Migrate WTF::Vector::append() to ::push_back() in binding templates (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

index bbea073618ebe5992dc19695ea8723754ac795bd..d32da99b2f0b7cfb2737815fb7cb53e9b36bfe63 100644

--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

@@ -283,7 +283,7 @@ void crossOriginNamedSetter(v8::Local<v8::Name> name, v8::Local<v8::Value> value

void crossOriginNamedEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info) {

Vector<String> names;

for (const auto& attribute : kCrossOriginAttributeTable)

- names.append(attribute.name);

+ names.push_back(attribute.name);

v8SetReturnValue(

info,

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('j') | no next file with comments »