Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2628973007: Migrate WTF::Vector::append() to ::push_back() in binding templates (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% filter format_blink_cpp_source_code %} 1 {% filter format_blink_cpp_source_code %}
2 2
3 {% include 'copyright_block.txt' %} 3 {% include 'copyright_block.txt' %}
4 #include "{{v8_class_or_partial}}.h" 4 #include "{{v8_class_or_partial}}.h"
5 5
6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %} 6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
7 #include "{{filename}}" 7 #include "{{filename}}"
8 {% endfor %} 8 {% endfor %}
9 9
10 namespace blink { 10 namespace blink {
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 BindingSecurity::failedAccessCheckFor( 276 BindingSecurity::failedAccessCheckFor(
277 info.GetIsolate(), 277 info.GetIsolate(),
278 {{v8_class}}::toImpl(info.Holder())->frame()); 278 {{v8_class}}::toImpl(info.Holder())->frame());
279 } 279 }
280 {% endif %} 280 {% endif %}
281 281
282 {% if has_cross_origin_named_enumerator %} 282 {% if has_cross_origin_named_enumerator %}
283 void crossOriginNamedEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info) { 283 void crossOriginNamedEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info) {
284 Vector<String> names; 284 Vector<String> names;
285 for (const auto& attribute : kCrossOriginAttributeTable) 285 for (const auto& attribute : kCrossOriginAttributeTable)
286 names.append(attribute.name); 286 names.push_back(attribute.name);
287 287
288 v8SetReturnValue( 288 v8SetReturnValue(
289 info, 289 info,
290 ToV8(names, info.Holder(), info.GetIsolate()).As<v8::Array>()); 290 ToV8(names, info.Holder(), info.GetIsolate()).As<v8::Array>());
291 } 291 }
292 {% endif %} 292 {% endif %}
293 293
294 {% if has_cross_origin_indexed_getter %} 294 {% if has_cross_origin_indexed_getter %}
295 void crossOriginIndexedGetter(uint32_t index, const v8::PropertyCallbackInfo<v8: :Value>& info) { 295 void crossOriginIndexedGetter(uint32_t index, const v8::PropertyCallbackInfo<v8: :Value>& info) {
296 {% if indexed_property_getter.is_custom %} 296 {% if indexed_property_getter.is_custom %}
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 {% block has_instance %}{% endblock %} 654 {% block has_instance %}{% endblock %}
655 {% block to_impl %}{% endblock %} 655 {% block to_impl %}{% endblock %}
656 {% block to_impl_with_type_check %}{% endblock %} 656 {% block to_impl_with_type_check %}{% endblock %}
657 {##############################################################################} 657 {##############################################################################}
658 {% block prepare_prototype_and_interface_object %}{% endblock %} 658 {% block prepare_prototype_and_interface_object %}{% endblock %}
659 {##############################################################################} 659 {##############################################################################}
660 {% block partial_interface %}{% endblock %} 660 {% block partial_interface %}{% endblock %}
661 } // namespace blink 661 } // namespace blink
662 662
663 {% endfilter %}{# format_blink_cpp_source_code #} 663 {% endfilter %}{# format_blink_cpp_source_code #}
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698