Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2628923004: Revert of PPC/s390: Internalize strings in-place (reland) (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of PPC/s390: Internalize strings in-place (reland) (patchset #1 id:1 of https://codereview.chromium.org/2628643002/ ) Reason for revert: Original CL https://codereview.chromium.org/2626893005 got reverted. Original issue's description: > PPC/s390: Internalize strings in-place (reland) > > Port 4c699e349a4986b28574b3a51e8780e3a3d067b1 > > Original Commit Message: > > using newly introduced ThinStrings, which store a pointer to the actual, > internalized string they represent. > > (Previously landed as #42168 / af51befe694f. > > R=jkummerow@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG=v8:4520 > LOG=N > > Review-Url: https://codereview.chromium.org/2628643002 > Cr-Commit-Position: refs/heads/master@{#42202} > Committed: https://chromium.googlesource.com/v8/v8/+/aa0cb2eaf830e03fced1e00134fb65938df02388 TBR=jkummerow@chromium.org,joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4520 Review-Url: https://codereview.chromium.org/2628923004 Cr-Commit-Position: refs/heads/master@{#42304} Committed: https://chromium.googlesource.com/v8/v8/+/d730551edcf7a07d3f16d5e22b589f0c198bbb21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/ppc/code-stubs-ppc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
JaideepBajwa
Created Revert of PPC/s390: Internalize strings in-place (reland)
3 years, 11 months ago (2017-01-12 23:43:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628923004/1
3 years, 11 months ago (2017-01-12 23:43:23 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-12 23:43:24 UTC) #5
john.yan
lgtm
3 years, 11 months ago (2017-01-13 04:54:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628923004/1
3 years, 11 months ago (2017-01-13 05:04:49 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 05:30:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d730551edcf7a07d3f16d5e22b589f0c198...

Powered by Google App Engine
This is Rietveld 408576698