Revert of Internalize strings in-place

Revert of Internalize strings in-place (patchset #20 id:380001 of https://codereview.chromium.org/2549773002/ )

Reason for revert:
Blocks roll, ASan detects leaking ExternalStrings.

Original issue's description:
> Internalize strings in-place (reland^2)
> 
> using newly introduced ThinStrings, which store a pointer to the actual,
> internalized string they represent.
> 
> BUG=v8:4520
> 
> (Previously landed as #42168 / af51befe694f)
> (Previously landed as #42193 / 4c699e349a49)
> 
> Review-Url: https://codereview.chromium.org/2549773002
> Cr-Commit-Position: refs/heads/master@{#42235}
> Committed: https://chromium.googlesource.com/v8/v8/+/ec45e6ed2e11698c713e664b1510bc31bcdbbdba

TBR=ishell@chromium.org,hpayer@chromium.org,bmeurer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4520
Review-Url: https://codereview.chromium.org/2626893005
Cr-Commit-Position: refs/heads/master@{#42271}
Committed: https://chromium.googlesource.com/v8/v8/+/b4654bf30e63499dd689472bcfde7fbf8c7484c7

[Jakob Kummerow, 2017-01-12 14:49:39]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-01-12 14:49:40]

Created Revert of Internalize strings in-place

[commit-bot: I haz the power, 2017-01-12 14:49:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 14:50:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 14:50:10]

Failed to apply patch for src/runtime/runtime-i18n.cc:
While running git apply --index -p1;
  error: patch failed: src/runtime/runtime-i18n.cc:1088
  error: src/runtime/runtime-i18n.cc: patch does not apply

Patch:       src/runtime/runtime-i18n.cc
Index: src/runtime/runtime-i18n.cc
diff --git a/src/runtime/runtime-i18n.cc b/src/runtime/runtime-i18n.cc
index
2d0c55eb217b1c328e09633d763f9c8d81c7bf8e..7554f99cbb7dd8f46cabe846db49e966173607bd
100644
--- a/src/runtime/runtime-i18n.cc
+++ b/src/runtime/runtime-i18n.cc
@@ -865,8 +865,6 @@
   Handle<SeqTwoByteString> result;
   std::unique_ptr<uc16[]> sap;
 
-  if (dest_length == 0) return isolate->heap()->empty_string();
-
   // This is not a real loop. It'll be executed only once (no overflow) or
   // twice (overflow).
   for (int i = 0; i < 2; ++i) {
@@ -1088,7 +1086,7 @@
   int32_t length = s->length();
   s = String::Flatten(s);
 
-  if (s->HasOnlyOneByteChars() && length > 0) {
+  if (s->HasOnlyOneByteChars()) {
     Handle<SeqOneByteString> result =
         isolate->factory()->NewRawOneByteString(length).ToHandleChecked();

[Jakob Kummerow, 2017-01-12 14:59:54]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:00:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 15:00:20]

CQ is committing da patch.

Bot data: {"patchset_id": 290001, "attempt_start_ts": 1484233194139130,
"parent_rev": "aa75904e3c2072f6b0d6ed92f75d1fb729d7cefa", "commit_rev":
"b4654bf30e63499dd689472bcfde7fbf8c7484c7"}

[commit-bot: I haz the power, 2017-01-12 15:00:27]

Description was changed from

==========
Revert of Internalize strings in-place (patchset #20 id:380001 of
https://codereview.chromium.org/2549773002/ )

Reason for revert:
Blocks roll, ASan detects leaking ExternalStrings.

Original issue's description:
> Internalize strings in-place (reland^2)
> 
> using newly introduced ThinStrings, which store a pointer to the actual,
> internalized string they represent.
> 
> BUG=v8:4520
> 
> (Previously landed as #42168 / af51befe694f)
> (Previously landed as #42193 / 4c699e349a49)
> 
> Review-Url: https://codereview.chromium.org/2549773002
> Cr-Commit-Position: refs/heads/master@{#42235}
> Committed:
https://chromium.googlesource.com/v8/v8/+/ec45e6ed2e11698c713e664b1510bc31bcd...

TBR=ishell@chromium.org,hpayer@chromium.org,bmeurer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4520
==========

to

==========
Revert of Internalize strings in-place (patchset #20 id:380001 of
https://codereview.chromium.org/2549773002/ )

Reason for revert:
Blocks roll, ASan detects leaking ExternalStrings.

Original issue's description:
> Internalize strings in-place (reland^2)
> 
> using newly introduced ThinStrings, which store a pointer to the actual,
> internalized string they represent.
> 
> BUG=v8:4520
> 
> (Previously landed as #42168 / af51befe694f)
> (Previously landed as #42193 / 4c699e349a49)
> 
> Review-Url: https://codereview.chromium.org/2549773002
> Cr-Commit-Position: refs/heads/master@{#42235}
> Committed:
https://chromium.googlesource.com/v8/v8/+/ec45e6ed2e11698c713e664b1510bc31bcd...

TBR=ishell@chromium.org,hpayer@chromium.org,bmeurer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4520

Review-Url: https://codereview.chromium.org/2626893005
Cr-Commit-Position: refs/heads/master@{#42271}
Committed:
https://chromium.googlesource.com/v8/v8/+/b4654bf30e63499dd689472bcfde7fbf8c7...
==========

[commit-bot: I haz the power, 2017-01-12 15:00:28]

Committed patchset #2 (id:290001) as
https://chromium.googlesource.com/v8/v8/+/b4654bf30e63499dd689472bcfde7fbf8c7...