Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2628643002: PPC/s390: Internalize strings in-place (reland) (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Internalize strings in-place (reland) Port 4c699e349a4986b28574b3a51e8780e3a3d067b1 Original Commit Message: using newly introduced ThinStrings, which store a pointer to the actual, internalized string they represent. (Previously landed as #42168 / af51befe694f. R=jkummerow@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4520 LOG=N Review-Url: https://codereview.chromium.org/2628643002 Cr-Commit-Position: refs/heads/master@{#42202} Committed: https://chromium.googlesource.com/v8/v8/+/aa0cb2eaf830e03fced1e00134fb65938df02388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/ppc/code-stubs-ppc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-10 21:13:15 UTC) #1
JoranSiu
On 2017/01/10 21:13:15, JaideepBajwa wrote: > ptal lgtm
3 years, 11 months ago (2017-01-10 21:39:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628643002/1
3 years, 11 months ago (2017-01-10 21:40:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/aa0cb2eaf830e03fced1e00134fb65938df02388
3 years, 11 months ago (2017-01-10 22:09:37 UTC) #7
JaideepBajwa
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2628923004/ by bjaideep@ca.ibm.com. ...
3 years, 11 months ago (2017-01-12 23:43:11 UTC) #8
Jakob Kummerow
On 2017/01/12 23:43:11, JaideepBajwa wrote: > A revert of this CL (patchset #1 id:1) has ...
3 years, 11 months ago (2017-01-13 12:04:34 UTC) #9
JaideepBajwa
3 years, 11 months ago (2017-01-13 16:29:43 UTC) #10
Message was sent while issue was closed.
On 2017/01/13 12:04:34, Jakob Kummerow wrote:
> On 2017/01/12 23:43:11, JaideepBajwa wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2628923004/ by mailto:bjaideep@ca.ibm.com.
> > 
> > The reason for reverting is: Original CL
> > https://codereview.chromium.org/2626893005 got reverted..
> 
> Sorry for the trouble. I'll include this fix in the reland.

Thank you.

Powered by Google App Engine
This is Rietveld 408576698