Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2628183002: The great shader refactor: Add YUV support to the uber shader (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 11 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The great shader refactor: Add YUV support to the uber shader This covers all cases except when color conversion is required. For color conversion, the existing video shaders convert directly from YUV to output RGB, which doesn't fit in with the rest of the shaders. The next step is to make color conversion always be RGB to RGB, and make color conversion be orthogonal to YUV versus RGB input. BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2628183002 Cr-Commit-Position: refs/heads/master@{#443758} Committed: https://chromium.googlesource.com/chromium/src/+/e5ba90a56a6e2249ef0f5782fef4c1b5bd0f878e

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -41 lines) Patch
M cc/output/gl_renderer.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download
M cc/output/program_binding.h View 4 chunks +14 lines, -12 lines 0 comments Download
M cc/output/program_binding.cc View 2 chunks +13 lines, -8 lines 0 comments Download
M cc/output/shader.h View 2 chunks +27 lines, -3 lines 0 comments Download
M cc/output/shader.cc View 11 chunks +70 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
ccameron
ptal (actual logic changes). I left the color conversion stuff untouched, because it has to ...
3 years, 11 months ago (2017-01-12 09:35:39 UTC) #4
enne (OOO)
lgtm
3 years, 11 months ago (2017-01-12 18:41:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628183002/20001
3 years, 11 months ago (2017-01-14 00:29:50 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 01:24:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e5ba90a56a6e2249ef0f5782fef4...

Powered by Google App Engine
This is Rietveld 408576698