Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2622053005: The great shader refactor: Merge YUV shader class (Closed)

Created:
3 years, 11 months ago by ccameron
Modified:
3 years, 11 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The great shader refactor: Merge YUV shader class This merges the YUV fragment shader into the base class, but only by adding a "if YUV then go do something completely different" clause. A subsequent patch will actually merge into the shader generation. Since we no longer have any sub-classes, get rid of the "Base" from the shader class names, and the templating of ProgramBinding (and rename it to just Program). BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2622053005 Cr-Commit-Position: refs/heads/master@{#443703} Committed: https://chromium.googlesource.com/chromium/src/+/6fead58e757f82f414c973a056e85006e80192dc

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -167 lines) Patch
M cc/output/gl_renderer.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 4 chunks +15 lines, -50 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M cc/output/program_binding.h View 8 chunks +66 lines, -31 lines 0 comments Download
M cc/output/program_binding.cc View 2 chunks +19 lines, -1 line 0 comments Download
M cc/output/shader.h View 8 chunks +26 lines, -52 lines 0 comments Download
M cc/output/shader.cc View 13 chunks +41 lines, -21 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (14 generated)
ccameron
ptal (just mechanical moving of stuff)
3 years, 11 months ago (2017-01-12 09:35:04 UTC) #6
enne (OOO)
lgtm
3 years, 11 months ago (2017-01-12 18:33:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622053005/20001
3 years, 11 months ago (2017-01-13 21:35:02 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 22:37:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6fead58e757f82f414c973a056e8...

Powered by Google App Engine
This is Rietveld 408576698