Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2627993002: mus-gpu: Include GpuPreferences when requesting for GpuService. (Closed)

Created:
3 years, 11 months ago by sadrul
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus-gpu: Include GpuPreferences when requesting for GpuService. The gpu host should set up GpuPreferences correctly and send that to the gpu process so that GpuService is initialized with the desired settings. The corresponding chrome-ipc, GpuMsg_Initialize, also includes the GpuPreferences. Also includes a build fix for mac. BUG=643746, 630895 Review-Url: https://codereview.chromium.org/2627993002 Cr-Commit-Position: refs/heads/master@{#442955} Committed: https://chromium.googlesource.com/chromium/src/+/273a38965bc5b14d88d54ae1b5eb455d0343f2b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -11 lines) Patch
M services/ui/gpu/gpu_main.h View 2 chunks +4 lines, -2 lines 0 comments Download
M services/ui/gpu/gpu_main.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M services/ui/gpu/gpu_service.h View 2 chunks +10 lines, -2 lines 0 comments Download
M services/ui/gpu/gpu_service.cc View 1 chunk +3 lines, -1 line 0 comments Download
M services/ui/gpu/interfaces/gpu_host.mojom View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_main.mojom View 2 chunks +3 lines, -1 line 0 comments Download
M services/ui/ws/gpu_host.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
sadrul
3 years, 11 months ago (2017-01-11 16:14:50 UTC) #5
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-11 17:50:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627993002/1
3 years, 11 months ago (2017-01-11 18:05:15 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 18:12:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/273a38965bc5b14d88d54ae1b5eb...

Powered by Google App Engine
This is Rietveld 408576698