Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2622393004: Remove obsolete RequestTrackerImpl::CancelRequests. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete RequestTrackerImpl::CancelRequests. RequestTrackerImpl::CancelRequests clear the content of live_requests_ but no object are ever added to that set and so is obsolete. BUG=585700 Review-Url: https://codereview.chromium.org/2622393004 Cr-Commit-Position: refs/heads/master@{#443568} Committed: https://chromium.googlesource.com/chromium/src/+/321d5537e38029ad053c0645492dd9edd30ea9d4

Patch Set 1 #

Patch Set 2 : Rebase on origin/master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M ios/web/net/request_tracker_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ios/web/net/request_tracker_impl.mm View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 11 months ago (2017-01-12 16:00:36 UTC) #3
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-12 16:08:37 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2615003002 Patch 120001). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-12 16:34:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622393004/20001
3 years, 11 months ago (2017-01-13 16:00:34 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 16:11:47 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/321d5537e38029ad053c0645492d...

Powered by Google App Engine
This is Rietveld 408576698