third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h - Issue 2627793002: Remove unused code in InvalidatableInterpolation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h

Issue 2627793002: Remove unused code in InvalidatableInterpolation (Closed)

Patch Set: Simplify test in response to review Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/InterpolationEffectTest.cpp ('k') | third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h

diff --git a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h

index bdacb924bc4ddb10fa6933d6ab791f51a28fe1bf..2fb90cc365528b307a1386e99b77a06bba41ffa4 100644

--- a/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h

+++ b/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h

@@ -30,7 +30,6 @@ class CORE_EXPORT InvalidatableInterpolation : public Interpolation {

PropertyHandle getProperty() const final { return m_property; }

virtual void interpolate(int iteration, double fraction);

bool dependsOnUnderlyingValue() const final;

- virtual void apply(InterpolationEnvironment&) const { NOTREACHED(); }

static void applyStack(const ActiveInterpolations&,

InterpolationEnvironment&);

@@ -51,11 +50,6 @@ class CORE_EXPORT InvalidatableInterpolation : public Interpolation {

using ConversionCheckers = InterpolationType::ConversionCheckers;

- InterpolableValue* getCachedValueForTesting() const final {

- // TODO(suzyh): Add meaningful implementation here

- NOTREACHED();

- return nullptr;

- }

std::unique_ptr<TypedInterpolationValue> maybeConvertUnderlyingValue(

const InterpolationEnvironment&) const;

const TypedInterpolationValue* ensureValidConversion(