Validate GN substitutions in args and rsp files.

Validate GN substitutions in args and rsp files.

Previously GN did not validate the substitution types used in the args or
response_file_contents for action_foreach targets. If a caller used an
incorrect one (as was happening in the nocompile test template), GN would
assert in debug mode and skip the substitution in release mode.

This didn't seem to cause a problem for the nocompile test because the output
file is not used.

This adds the necessary validation for these types so GN will give a proper
error message on misuse, and adds some additional unit tests for other aspects
of action_foreach parameter validation.

Review-Url: https://codereview.chromium.org/2627703002
Cr-Commit-Position: refs/heads/master@{#444507}
Committed: https://chromium.googlesource.com/chromium/src/+/bb57bea1642b294af0578ab0e50d1c63bb5491b2

[brettw, 2017-01-10 21:26:12]

Format

[brettw, 2017-01-10 21:26:18]

Description was changed from

==========
Validate GN substitutions in args and rsp files.

Previously GN did not validate the substitution types used in the args or
response_file_contents for action_foreach targets. If a caller used an
incorrect one (as was happening in the nocompile test template), GN would
assert in debug mode and skip the substitution in release mode.

This adds the necessary validation for these types so GN will give a proper
error message on misuse, and adds some additional unit tests for other aspects
of action_foreach parameter validation.
==========

to

==========
Validate GN substitutions in args and rsp files.

Previously GN did not validate the substitution types used in the args or
response_file_contents for action_foreach targets. If a caller used an
incorrect one (as was happening in the nocompile test template), GN would
assert in debug mode and skip the substitution in release mode.

This adds the necessary validation for these types so GN will give a proper
error message on misuse, and adds some additional unit tests for other aspects
of action_foreach parameter validation.
==========

[brettw, 2017-01-10 21:26:19]

brettw@chromium.org changed reviewers:
+ tsniatowski@opera.com

[brettw, 2017-01-10 21:26:39]

I think you also noticed this assertion...

[brettw, 2017-01-10 21:26:43]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 21:27:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2017-01-10 21:39:40]

Description was changed from

==========
Validate GN substitutions in args and rsp files.

Previously GN did not validate the substitution types used in the args or
response_file_contents for action_foreach targets. If a caller used an
incorrect one (as was happening in the nocompile test template), GN would
assert in debug mode and skip the substitution in release mode.

This adds the necessary validation for these types so GN will give a proper
error message on misuse, and adds some additional unit tests for other aspects
of action_foreach parameter validation.
==========

to

==========
Validate GN substitutions in args and rsp files.

Previously GN did not validate the substitution types used in the args or
response_file_contents for action_foreach targets. If a caller used an
incorrect one (as was happening in the nocompile test template), GN would
assert in debug mode and skip the substitution in release mode.

This didn't seem to cause a problem for the nocompile test because the output
file is not used.

This adds the necessary validation for these types so GN will give a proper
error message on misuse, and adds some additional unit tests for other aspects
of action_foreach parameter validation.
==========

[commit-bot: I haz the power, 2017-01-10 22:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 22:46:54]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-01-17 19:00:10]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org
- tsniatowski@opera.com

[brettw, 2017-01-17 19:00:10]

-> Dirk

[brettw, 2017-01-17 19:06:39]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 19:06:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 20:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 20:10:13]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-01-18 21:00:19]

lgtm

[brettw, 2017-01-18 21:12:42]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:13:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 22:11:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484773962180930,
"parent_rev": "bd39285aa28687c03e726e2b08d50c258d16c088", "commit_rev":
"bb57bea1642b294af0578ab0e50d1c63bb5491b2"}

[commit-bot: I haz the power, 2017-01-18 22:11:40]

Description was changed from

==========
Validate GN substitutions in args and rsp files.

Previously GN did not validate the substitution types used in the args or
response_file_contents for action_foreach targets. If a caller used an
incorrect one (as was happening in the nocompile test template), GN would
assert in debug mode and skip the substitution in release mode.

This didn't seem to cause a problem for the nocompile test because the output
file is not used.

This adds the necessary validation for these types so GN will give a proper
error message on misuse, and adds some additional unit tests for other aspects
of action_foreach parameter validation.
==========

to

==========
Validate GN substitutions in args and rsp files.

Previously GN did not validate the substitution types used in the args or
response_file_contents for action_foreach targets. If a caller used an
incorrect one (as was happening in the nocompile test template), GN would
assert in debug mode and skip the substitution in release mode.

This didn't seem to cause a problem for the nocompile test because the output
file is not used.

This adds the necessary validation for these types so GN will give a proper
error message on misuse, and adds some additional unit tests for other aspects
of action_foreach parameter validation.

Review-Url: https://codereview.chromium.org/2627703002
Cr-Commit-Position: refs/heads/master@{#444507}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb57bea1642b294af0578ab0e50d...
==========

[commit-bot: I haz the power, 2017-01-18 22:11:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bb57bea1642b294af0578ab0e50d...