tools/gn/ninja_action_target_writer.cc - Issue 2627703002: Validate GN substitutions in args and rsp files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_action_target_writer.cc

Issue 2627703002: Validate GN substitutions in args and rsp files. (Closed)

Patch Set: Format Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_action_target_writer.cc

diff --git a/tools/gn/ninja_action_target_writer.cc b/tools/gn/ninja_action_target_writer.cc

index 77ee2b41ae6017105dc79ec845baa1518c8f8744..9e5636237a3b16f77c324101f5e815e29494780c 100644

--- a/tools/gn/ninja_action_target_writer.cc

+++ b/tools/gn/ninja_action_target_writer.cc

@@ -180,7 +180,7 @@ void NinjaActionTargetWriter::WriteSourceRules(

// The required types is the union of the args and response file. This

// might theoretically duplicate a definition if the same substitution is

- // used in both the args and the reponse file. However, this should be

+ // used in both the args and the response file. However, this should be

// very unusual (normally the substitutions will go in one place or the

// other) and the redundant assignment won't bother Ninja.

SubstitutionWriter::WriteNinjaVariablesForSource(

« no previous file with comments | « tools/gn/action_target_generator_unittest.cc ('k') | tools/gn/substitution_type.h » ('j') | no next file with comments »