Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tools/gn/target_generator.cc

Issue 2627703002: Validate GN substitutions in args and rsp files. (Closed)
Patch Set: Format Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/substitution_type.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target_generator.cc
diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc
index 7fe64fd8b091ba5b1e3688b8c2aeffc52f45e060..ca193b646d9c1f11526a70bb4acd8de34bb72c7a 100644
--- a/tools/gn/target_generator.cc
+++ b/tools/gn/target_generator.cc
@@ -312,8 +312,9 @@ bool TargetGenerator::FillOutputs(bool allow_substitutions) {
}
// Check the substitutions used are valid for this purpose.
- if (!EnsureValidSourcesSubstitutions(outputs.required_types(),
- value->origin(), err_))
+ if (!EnsureValidSubstitutions(outputs.required_types(),
+ &IsValidSourceSubstitution,
+ value->origin(), err_))
return false;
// Validate that outputs are in the output dir.
« no previous file with comments | « tools/gn/substitution_type.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698