Plugin Power Saver: Refactor some Tiny plugin code and tests.

Plugin Power Saver: Refactor some Tiny plugin code and tests.

In preparation to also filter same-origin tiny plugins, this CL:

 1) Updates the browser test to also test that the Omnibox icon is shown
    when tiny plugins are blocked. (Accidentally regressed this in
    original CL).

 2) Fixes obsolete enum naming to reflect that TINY plugins have
    complex treatment (rather than always being marked essential).

 3) Fixes obsolete enum naming for UNKNOWN_SIZE also.

BUG=675707
Review-Url: https://codereview.chromium.org/2627513002
Cr-Commit-Position: refs/heads/master@{#442674}
Committed: https://chromium.googlesource.com/chromium/src/+/c3a36842e3a92c456fd2c9c2e99f8da6f1cde2f8

[tommycli, 2017-01-10 01:14:45]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:15:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-10 01:25:21]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2017-01-10 01:25:44]

Description was changed from

==========
Plugin Power Saver: Refactor some Tiny plugin code and tests.

In preparation to also filter same-origin tiny plugins, this CL:

 1) Updates the browser test to also test that the Omnibox icon is shown
    when tiny plugins are blocked. (Accidentally regressed this in
    original CL).

 2) Fixes obsolete enum naming to reflect that TINY plugins have
    complex treatment (rather than always being marked essential).

BUG=675707
==========

to

==========
Plugin Power Saver: Refactor some Tiny plugin code and tests.

In preparation to also filter same-origin tiny plugins, this CL:

 1) Updates the browser test to also test that the Omnibox icon is shown
    when tiny plugins are blocked. (Accidentally regressed this in
    original CL).

 2) Fixes obsolete enum naming to reflect that TINY plugins have
    complex treatment (rather than always being marked essential).

 3) Fixes obsolete enum naming for UNKNOWN_SIZE also.

BUG=675707
==========

[commit-bot: I haz the power, 2017-01-10 01:26:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-10 01:28:11]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:28:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-10 02:08:09]

tommycli@chromium.org changed reviewers:
+ jochen@chromium.org

[tommycli, 2017-01-10 02:24:39]

jochen: PTAL,

This CL has no behavior changes, but fixes some outdated names and adds a test
for:

https://codereview.chromium.org/2627493002/

Without this CL, the above patchset would be confusing.

[commit-bot: I haz the power, 2017-01-10 03:30:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:30:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[jochen (gone - plz use gerrit), 2017-01-10 09:49:24]

I can only approve UseCounter additions to histograms.xml - please ask somebody
from tools/metrics/OWNERS to approve the histograms.xml change

the code changes lgtm

[tommycli, 2017-01-10 16:09:44]

On 2017/01/10 09:49:24, jochen wrote:
> I can only approve UseCounter additions to histograms.xml - please ask
somebody
> from tools/metrics/OWNERS to approve the histograms.xml change
> 
> the code changes lgtm

jochen: thanks!

[tommycli, 2017-01-10 16:10:00]

tommycli@chromium.org changed reviewers:
+ isherman@chromium.org

[tommycli, 2017-01-10 16:10:00]

isherman: PTAL histograms.xml

[tommycli, 2017-01-10 17:10:20]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 17:10:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 17:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 17:14:23]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-01-10 20:26:08]

histograms.xml lgtm

[Ilya Sherman, 2017-01-10 20:26:25]

The CQ bit was checked by isherman@chromium.org

[tommycli, 2017-01-10 20:26:39]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-01-10 20:26:39]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-01-10 20:26:48]

On 2017/01/10 20:26:08, Ilya Sherman wrote:
> histograms.xml lgtm

isherman: Thanks!

[tommycli, 2017-01-10 20:27:14]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-01-10 20:27:14]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-01-10 20:27:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 20:34:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484080034378550,
"parent_rev": "6e8fc783e647eab80bde154c9783d0995d20b4ad", "commit_rev":
"c3a36842e3a92c456fd2c9c2e99f8da6f1cde2f8"}

[commit-bot: I haz the power, 2017-01-10 20:34:54]

Description was changed from

==========
Plugin Power Saver: Refactor some Tiny plugin code and tests.

In preparation to also filter same-origin tiny plugins, this CL:

 1) Updates the browser test to also test that the Omnibox icon is shown
    when tiny plugins are blocked. (Accidentally regressed this in
    original CL).

 2) Fixes obsolete enum naming to reflect that TINY plugins have
    complex treatment (rather than always being marked essential).

 3) Fixes obsolete enum naming for UNKNOWN_SIZE also.

BUG=675707
==========

to

==========
Plugin Power Saver: Refactor some Tiny plugin code and tests.

In preparation to also filter same-origin tiny plugins, this CL:

 1) Updates the browser test to also test that the Omnibox icon is shown
    when tiny plugins are blocked. (Accidentally regressed this in
    original CL).

 2) Fixes obsolete enum naming to reflect that TINY plugins have
    complex treatment (rather than always being marked essential).

 3) Fixes obsolete enum naming for UNKNOWN_SIZE also.

BUG=675707

Review-Url: https://codereview.chromium.org/2627513002
Cr-Commit-Position: refs/heads/master@{#442674}
Committed:
https://chromium.googlesource.com/chromium/src/+/c3a36842e3a92c456fd2c9c2e99f...
==========

[commit-bot: I haz the power, 2017-01-10 20:34:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c3a36842e3a92c456fd2c9c2e99f...