components/plugins/renderer/loadable_plugin_placeholder.cc - Issue 2627513002: Plugin Power Saver: Refactor some Tiny plugin code and tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.cc

Issue 2627513002: Plugin Power Saver: Refactor some Tiny plugin code and tests. (Closed)

Patch Set: Also update histograms.xml Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/plugins/renderer/loadable_plugin_placeholder.cc

diff --git a/components/plugins/renderer/loadable_plugin_placeholder.cc b/components/plugins/renderer/loadable_plugin_placeholder.cc

index 1669c07542206dfbd963c46e84c050fc2e26f700..3496764e1d5d03c2dc7d4f376dab4d61b3eaf235 100644

--- a/components/plugins/renderer/loadable_plugin_placeholder.cc

+++ b/components/plugins/renderer/loadable_plugin_placeholder.cc

@@ -209,8 +209,7 @@ void LoadablePluginPlaceholder::OnUnobscuredRectUpdate(

: RenderFrame::RECORD_DECISION);

bool plugin_is_tiny_and_blocked =

- is_blocked_for_tinyness_ &&

- status == RenderFrame::CONTENT_STATUS_ESSENTIAL_CROSS_ORIGIN_TINY;

+ is_blocked_for_tinyness_ && status == RenderFrame::CONTENT_STATUS_TINY;

// Early exit for plugins that we've discovered to be essential.

if (!plugin_is_tiny_and_blocked &&