[PPS] Exclude same-origin tiny plugins.

[PPS] Exclude same-origin tiny plugins.

Tiny plugins will now always be disabled by plugin power saver, even if they have the same origin as the main page.

BUG=675707
patch from issue 2576893003 at patchset 1 (http://crrev.com/2576893003#ps1)

Review-Url: https://codereview.chromium.org/2627493002
Cr-Commit-Position: refs/heads/master@{#443127}
Committed: https://chromium.googlesource.com/chromium/src/+/4d26738f00698ad57b12bf969251513b5260f954

[tommycli, 2017-01-10 02:03:27]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2017-01-10 02:03:50]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-01-10 02:04:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-10 02:23:09]

Description was changed from

==========
[PPS] Exclude same-origin tiny plugins.

Tiny plugins will now always be disabled by plugin power saver, even if they
have the same origin as the main page.

BUG=675707

patch from issue 2576893003 at patchset 1 (http://crrev.com/2576893003#ps1)
==========

to

==========
[PPS] Exclude same-origin tiny plugins.

Tiny plugins will now always be disabled by plugin power saver, even if they
have the same origin as the main page.

BUG=675707

patch from issue 2576893003 at patchset 1 (http://crrev.com/2576893003#ps1)
==========

[tommycli, 2017-01-10 02:23:10]

tommycli@chromium.org changed reviewers:
+ jochen@chromium.org

[tommycli, 2017-01-10 16:10:11]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 16:10:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-10 16:27:01]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 16:27:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-10 17:06:00]

jochen: PTAL, thanks!

[commit-bot: I haz the power, 2017-01-10 18:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 18:14:31]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-11 09:48:07]

lgtm

https://codereview.chromium.org/2627493002/diff/80001/chrome/browser/plugins/...
File chrome/browser/plugins/plugin_power_saver_browsertest.cc (right):

https://codereview.chromium.org/2627493002/diff/80001/chrome/browser/plugins/...
chrome/browser/plugins/plugin_power_saver_browsertest.cc:607: void
SetUpInProcessBrowserTestFixture() override {
nit. please add a virtual dtor

[tommycli, 2017-01-11 18:34:40]

https://codereview.chromium.org/2627493002/diff/80001/chrome/browser/plugins/...
File chrome/browser/plugins/plugin_power_saver_browsertest.cc (right):

https://codereview.chromium.org/2627493002/diff/80001/chrome/browser/plugins/...
chrome/browser/plugins/plugin_power_saver_browsertest.cc:607: void
SetUpInProcessBrowserTestFixture() override {
On 2017/01/11 09:48:06, jochen wrote:
> nit. please add a virtual dtor

Hey. The base class doesn't have an explicitly declared virtual destructor
either. I noticed many inheritors of InProcessBrowserTest also don't. Do you
still want me to add an explicit virtual destructor to all of these? (There are
about 4 in this file)

[tommycli, 2017-01-12 01:14:14]

On 2017/01/11 18:34:40, tommycli wrote:
>
https://codereview.chromium.org/2627493002/diff/80001/chrome/browser/plugins/...
> File chrome/browser/plugins/plugin_power_saver_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2627493002/diff/80001/chrome/browser/plugins/...
> chrome/browser/plugins/plugin_power_saver_browsertest.cc:607: void
> SetUpInProcessBrowserTestFixture() override {
> On 2017/01/11 09:48:06, jochen wrote:
> > nit. please add a virtual dtor
> 
> Hey. The base class doesn't have an explicitly declared virtual destructor
> either. I noticed many inheritors of InProcessBrowserTest also don't. Do you
> still want me to add an explicit virtual destructor to all of these? (There
are
> about 4 in this file)

I'm going to check CQ. Feel free to uncheck or request that I add those virtual
dtors in a separate CL.

[tommycli, 2017-01-12 01:14:20]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-01-12 01:15:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:52:07]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484183660543680,
"parent_rev": "f2a1967c8a9541cdcef363c78a100eb8539b916a", "commit_rev":
"4d26738f00698ad57b12bf969251513b5260f954"}

[commit-bot: I haz the power, 2017-01-12 02:52:32]

Description was changed from

==========
[PPS] Exclude same-origin tiny plugins.

Tiny plugins will now always be disabled by plugin power saver, even if they
have the same origin as the main page.

BUG=675707

patch from issue 2576893003 at patchset 1 (http://crrev.com/2576893003#ps1)
==========

to

==========
[PPS] Exclude same-origin tiny plugins.

Tiny plugins will now always be disabled by plugin power saver, even if they
have the same origin as the main page.

BUG=675707

patch from issue 2576893003 at patchset 1 (http://crrev.com/2576893003#ps1)

Review-Url: https://codereview.chromium.org/2627493002
Cr-Commit-Position: refs/heads/master@{#443127}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d26738f00698ad57b12bf969251...
==========

[commit-bot: I haz the power, 2017-01-12 02:52:33]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4d26738f00698ad57b12bf969251...