Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2627433002: Revert of Dont build Ozone/LinuxOS compile bot with enable_package_mash_services=true (Closed)

Created:
3 years, 11 months ago by tonikitoo
Modified:
3 years, 11 months ago
CC:
chromium-reviews, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Dont build Ozone/LinuxOS compile bot with enable_package_mash_services=true (patchset #1 id:1 of https://codereview.chromium.org/2614713004/ ) Reason for revert: Agreed with @thomasanderson that past [1] we should continue to build ozone/linux with enable_package_mash_services=true now that --window-manager=simple_vm can be used. [1] https://codereview.chromium.org/2620503002/ Original issue's description: > Dont build Ozone/LinuxOS compile bot with enable_package_mash_services=true > > This should bring the Ozone/LinuxOS builds back building (not running). > > Review-Url: https://codereview.chromium.org/2614713004 > Cr-Commit-Position: refs/heads/master@{#441744} > Committed: https://chromium.googlesource.com/chromium/src/+/b69a8c43e07497ebd2d6603bbda27ed36a1cc541 TBR=thomasanderson@google.com,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2627433002 Cr-Commit-Position: refs/heads/master@{#442377} Committed: https://chromium.googlesource.com/chromium/src/+/c9a06c811d1fcbad634cd66ef0fe9871018ea738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
tonikitoo
Created Revert of Dont build Ozone/LinuxOS compile bot with enable_package_mash_services=true
3 years, 11 months ago (2017-01-09 20:58:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627433002/1
3 years, 11 months ago (2017-01-09 20:58:44 UTC) #3
Tom (Use chromium acct)
lgtm
3 years, 11 months ago (2017-01-09 20:59:59 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 22:30:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c9a06c811d1fcbad634cd66ef0fe...

Powered by Google App Engine
This is Rietveld 408576698