Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2614713004: Dont build Ozone/LinuxOS compile bot with enable_package_mash_services=true (Closed)

Created:
3 years, 11 months ago by tonikitoo
Modified:
3 years, 11 months ago
CC:
chromium-reviews, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dont build Ozone/LinuxOS compile bot with enable_package_mash_services=true This should bring the Ozone/LinuxOS builds back building (not running). Review-Url: https://codereview.chromium.org/2614713004 Cr-Commit-Position: refs/heads/master@{#441744} Committed: https://chromium.googlesource.com/chromium/src/+/b69a8c43e07497ebd2d6603bbda27ed36a1cc541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
tonikitoo
3 years, 11 months ago (2017-01-05 15:44:36 UTC) #3
Tom (Use chromium acct)
lgtm you'll need dpranke@ for OWNERS approval
3 years, 11 months ago (2017-01-05 20:24:28 UTC) #9
Tom (Use chromium acct)
lgtm you'll need dpranke@ for OWNERS approval
3 years, 11 months ago (2017-01-05 20:24:30 UTC) #10
Dirk Pranke
rs- lgtm :).
3 years, 11 months ago (2017-01-05 20:27:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614713004/1
3 years, 11 months ago (2017-01-05 20:40:23 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b69a8c43e07497ebd2d6603bbda27ed36a1cc541
3 years, 11 months ago (2017-01-05 20:46:06 UTC) #16
tonikitoo
3 years, 11 months ago (2017-01-09 20:58:05 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2627433002/ by tonikitoo@igalia.com.

The reason for reverting is: Agreed with @thomasanderson that past [1] we should
continue to build ozone/linux with 
enable_package_mash_services=true now that --window-manager=simple_vm can be
used.

[1] https://codereview.chromium.org/2620503002/.

Powered by Google App Engine
This is Rietveld 408576698