Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2620503002: nogncheck some includes guarded under OS_CHROMEOS (Closed)

Created:
3 years, 11 months ago by tonikitoo
Modified:
3 years, 11 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, kalyank, sadrul, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

nogncheck some includes guarded under OS_CHROMEOS Past [1], 'ash/*' became a dependency tiedly coupled with 'is_chromeos'. This, for various reasons, helped to simplify the dependency tree of mus+ash. However, with the introduction of simple_wm [2], it should still be possible to build and run Chrome/Ozone targeting LinuxOS (not ChromeOS), with 'enable_package_mash_services' ON. For that, this CL eases the gn checks for CHROMEOS specific header inclusions in mash/package/mash_packaged_service.cc. TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm [1] https://codereview.chromium.org/2549583002 [2] https://codereview.chromium.org/2511233002 BUG=666775 Review-Url: https://codereview.chromium.org/2620503002 Cr-Commit-Position: refs/heads/master@{#441978} Committed: https://chromium.googlesource.com/chromium/src/+/00d50f2e63ac31615026ad0f09e3a7b196fde53d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M mash/package/mash_packaged_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
fwang
Informal L G T M
3 years, 11 months ago (2017-01-06 16:17:50 UTC) #3
tonikitoo
@jamescook: PTAL
3 years, 11 months ago (2017-01-06 16:45:52 UTC) #9
James Cook
LGTM I chatted with sky briefly about this, he's OK with enable_mash_packaged_service working on non-cros ...
3 years, 11 months ago (2017-01-06 17:05:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620503002/1
3 years, 11 months ago (2017-01-06 17:19:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/336515)
3 years, 11 months ago (2017-01-06 17:25:20 UTC) #14
tonikitoo
On 2017/01/06 17:05:10, James Cook wrote: > LGTM > > I chatted with sky briefly ...
3 years, 11 months ago (2017-01-06 17:28:53 UTC) #16
sky
LGTM
3 years, 11 months ago (2017-01-06 18:10:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620503002/1
3 years, 11 months ago (2017-01-06 18:14:56 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 18:19:36 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00d50f2e63ac31615026ad0f09e3...

Powered by Google App Engine
This is Rietveld 408576698