|
|
Descriptionnogncheck some includes guarded under OS_CHROMEOS
Past [1], 'ash/*' became a dependency tiedly coupled with
'is_chromeos'. This, for various reasons, helped to simplify the
dependency tree of mus+ash.
However, with the introduction of simple_wm [2], it should still be
possible to build and run Chrome/Ozone targeting LinuxOS
(not ChromeOS), with 'enable_package_mash_services' ON.
For that, this CL eases the gn checks for CHROMEOS specific header
inclusions in mash/package/mash_packaged_service.cc.
TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm
[1] https://codereview.chromium.org/2549583002
[2] https://codereview.chromium.org/2511233002
BUG=666775
Review-Url: https://codereview.chromium.org/2620503002
Cr-Commit-Position: refs/heads/master@{#441978}
Committed: https://chromium.googlesource.com/chromium/src/+/00d50f2e63ac31615026ad0f09e3a7b196fde53d
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
The CQ bit was checked by tonikitoo@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Informal L G T M
Description was changed from ========== nogncheck some includes guarded under OS_CHROMEOS Past [2], 'ash/*' became a dependency coupled with 'is_chromeos'. This for various reasons helped to simplify the dependency tree of mus+ash. [1] https://codereview.chromium.org/2549583002. However, with the introduction of simple_wm [2], it should still be possible to build Chrome/Ozone targeting LinuxOS (not ChromeOS), with 'enable_package_mash_services' ON. For that, this CL eases the gn checks for CHROMEOS specific header inclusions in mash/package/mash_packaged_service.cc. TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm BUG=666775 ========== to ========== nogncheck some includes guarded under OS_CHROMEOS Past [1], 'ash/*' became a dependency coupled with 'is_chromeos'. This for various reasons helped to simplify the dependency tree of mus+ash. However, with the introduction of simple_wm [2], it should still be possible to build Chrome/Ozone targeting LinuxOS (not ChromeOS), with 'enable_package_mash_services' ON. For that, this CL eases the gn checks for CHROMEOS specific header inclusions in mash/package/mash_packaged_service.cc. TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm [1] https://codereview.chromium.org/2549583002 [2] https://codereview.chromium.org/2511233002 BUG=666775 ==========
tonikitoo@igalia.com changed reviewers: + jamescook@chromium.org
Description was changed from ========== nogncheck some includes guarded under OS_CHROMEOS Past [1], 'ash/*' became a dependency coupled with 'is_chromeos'. This for various reasons helped to simplify the dependency tree of mus+ash. However, with the introduction of simple_wm [2], it should still be possible to build Chrome/Ozone targeting LinuxOS (not ChromeOS), with 'enable_package_mash_services' ON. For that, this CL eases the gn checks for CHROMEOS specific header inclusions in mash/package/mash_packaged_service.cc. TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm [1] https://codereview.chromium.org/2549583002 [2] https://codereview.chromium.org/2511233002 BUG=666775 ========== to ========== nogncheck some includes guarded under OS_CHROMEOS Past [1], 'ash/*' became a dependency tiedly coupled with 'is_chromeos'. This, for various reasons, helped to simplify the dependency tree of mus+ash. However, with the introduction of simple_wm [2], it should still be possible to build and run Chrome/Ozone targeting LinuxOS (not ChromeOS), with 'enable_package_mash_services' ON. For that, this CL eases the gn checks for CHROMEOS specific header inclusions in mash/package/mash_packaged_service.cc. TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm [1] https://codereview.chromium.org/2549583002 [2] https://codereview.chromium.org/2511233002 BUG=666775 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
@jamescook: PTAL
LGTM I chatted with sky briefly about this, he's OK with enable_mash_packaged_service working on non-cros Linux.
The CQ bit was checked by tonikitoo@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
tonikitoo@igalia.com changed reviewers: + sky@chromium.org
On 2017/01/06 17:05:10, James Cook wrote: > LGTM > > I chatted with sky briefly about this, he's OK with enable_mash_packaged_service > working on non-cros Linux. Ok, thanks. +sky for ownership review.
LGTM
The CQ bit was checked by tonikitoo@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1483726463091170, "parent_rev": "e69c7ba12dee4e962d7f66ad6f71aea671b1898c", "commit_rev": "00d50f2e63ac31615026ad0f09e3a7b196fde53d"}
Message was sent while issue was closed.
Description was changed from ========== nogncheck some includes guarded under OS_CHROMEOS Past [1], 'ash/*' became a dependency tiedly coupled with 'is_chromeos'. This, for various reasons, helped to simplify the dependency tree of mus+ash. However, with the introduction of simple_wm [2], it should still be possible to build and run Chrome/Ozone targeting LinuxOS (not ChromeOS), with 'enable_package_mash_services' ON. For that, this CL eases the gn checks for CHROMEOS specific header inclusions in mash/package/mash_packaged_service.cc. TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm [1] https://codereview.chromium.org/2549583002 [2] https://codereview.chromium.org/2511233002 BUG=666775 ========== to ========== nogncheck some includes guarded under OS_CHROMEOS Past [1], 'ash/*' became a dependency tiedly coupled with 'is_chromeos'. This, for various reasons, helped to simplify the dependency tree of mus+ash. However, with the introduction of simple_wm [2], it should still be possible to build and run Chrome/Ozone targeting LinuxOS (not ChromeOS), with 'enable_package_mash_services' ON. For that, this CL eases the gn checks for CHROMEOS specific header inclusions in mash/package/mash_packaged_service.cc. TEST=<out>/chrome --mash --ozone-platform={x11|wayland} --window-manager=simple_wm [1] https://codereview.chromium.org/2549583002 [2] https://codereview.chromium.org/2511233002 BUG=666775 Review-Url: https://codereview.chromium.org/2620503002 Cr-Commit-Position: refs/heads/master@{#441978} Committed: https://chromium.googlesource.com/chromium/src/+/00d50f2e63ac31615026ad0f09e3... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/00d50f2e63ac31615026ad0f09e3... |