Make ExtensionIconSet::ContainsPath use StringPiece.

Make ExtensionIconSet::ContainsPath use StringPiece.

Also update callers to use better way to construct the path using
StringPiece-s, avoiding string copy (GURL::path()) and substring
copy (std::string::substr(1)).

Move ExtensionIconSet's unittest to extensions/

BUG=None

Review-Url: https://codereview.chromium.org/2626923002
Cr-Commit-Position: refs/heads/master@{#443032}
Committed: https://chromium.googlesource.com/chromium/src/+/ebb08805ae19aa64793d42f13eeb965363f5ab5c

[lazyboy, 2017-01-11 02:42:23]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:43:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:01:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:01:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lazyboy, 2017-01-11 19:32:44]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2017-01-11 19:52:19]

lgtm!

[lazyboy, 2017-01-11 21:08:35]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2017-01-11 21:09:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:51:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484168915399180, "parent_rev":
"a3d1d625473e380e09c9c3205cc2af0677f9af96", "commit_rev":
"ebb08805ae19aa64793d42f13eeb965363f5ab5c"}

[commit-bot: I haz the power, 2017-01-11 22:52:16]

Description was changed from

==========
Make ExtensionIconSet::ContainsPath use StringPiece.

Also update callers to use better way to construct the path using
StringPiece-s, avoiding string copy (GURL::path()) and substring
copy (std::string::substr(1)).

Move ExtensionIconSet's unittest to extensions/

BUG=None
==========

to

==========
Make ExtensionIconSet::ContainsPath use StringPiece.

Also update callers to use better way to construct the path using
StringPiece-s, avoiding string copy (GURL::path()) and substring
copy (std::string::substr(1)).

Move ExtensionIconSet's unittest to extensions/

BUG=None

Review-Url: https://codereview.chromium.org/2626923002
Cr-Commit-Position: refs/heads/master@{#443032}
Committed:
https://chromium.googlesource.com/chromium/src/+/ebb08805ae19aa64793d42f13eeb...
==========

[commit-bot: I haz the power, 2017-01-11 22:52:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ebb08805ae19aa64793d42f13eeb...