Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Side by Side Diff: extensions/common/extension_icon_set_unittest.cc

Issue 2626923002: Make ExtensionIconSet::ContainsPath use StringPiece. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/common/extension_icon_set.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/extension_icon_set.h" 5 #include "extensions/common/extension_icon_set.h"
6 6
7 #include "extensions/common/constants.h" 7 #include "extensions/common/constants.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace { 10 namespace {
11 11
12 TEST(ExtensionIconSet, Basic) { 12 TEST(ExtensionIconSetTest, Basic) {
13 ExtensionIconSet icons; 13 ExtensionIconSet icons;
14 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_LARGE, 14 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_LARGE,
15 ExtensionIconSet::MATCH_EXACTLY)); 15 ExtensionIconSet::MATCH_EXACTLY));
16 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_LARGE, 16 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_LARGE,
17 ExtensionIconSet::MATCH_BIGGER)); 17 ExtensionIconSet::MATCH_BIGGER));
18 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_LARGE, 18 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_LARGE,
19 ExtensionIconSet::MATCH_SMALLER)); 19 ExtensionIconSet::MATCH_SMALLER));
20 EXPECT_TRUE(icons.map().empty()); 20 EXPECT_TRUE(icons.map().empty());
21 21
22 icons.Add(extension_misc::EXTENSION_ICON_LARGE, "large.png"); 22 icons.Add(extension_misc::EXTENSION_ICON_LARGE, "large.png");
23 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_LARGE, 23 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_LARGE,
24 ExtensionIconSet::MATCH_EXACTLY)); 24 ExtensionIconSet::MATCH_EXACTLY));
25 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_LARGE, 25 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_LARGE,
26 ExtensionIconSet::MATCH_BIGGER)); 26 ExtensionIconSet::MATCH_BIGGER));
27 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_LARGE, 27 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_LARGE,
28 ExtensionIconSet::MATCH_SMALLER)); 28 ExtensionIconSet::MATCH_SMALLER));
29 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_MEDIUM, 29 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_MEDIUM,
(...skipping 15 matching lines...) Expand all
45 EXPECT_EQ("small.png", icons.Get(extension_misc::EXTENSION_ICON_MEDIUM, 45 EXPECT_EQ("small.png", icons.Get(extension_misc::EXTENSION_ICON_MEDIUM,
46 ExtensionIconSet::MATCH_SMALLER)); 46 ExtensionIconSet::MATCH_SMALLER));
47 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_MEDIUM, 47 EXPECT_EQ("large.png", icons.Get(extension_misc::EXTENSION_ICON_MEDIUM,
48 ExtensionIconSet::MATCH_BIGGER)); 48 ExtensionIconSet::MATCH_BIGGER));
49 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_BITTY, 49 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_BITTY,
50 ExtensionIconSet::MATCH_SMALLER)); 50 ExtensionIconSet::MATCH_SMALLER));
51 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_GIGANTOR, 51 EXPECT_EQ("", icons.Get(extension_misc::EXTENSION_ICON_GIGANTOR,
52 ExtensionIconSet::MATCH_BIGGER)); 52 ExtensionIconSet::MATCH_BIGGER));
53 } 53 }
54 54
55 TEST(ExtensionIconSet, Values) { 55 TEST(ExtensionIconSetTest, Values) {
56 ExtensionIconSet icons; 56 ExtensionIconSet icons;
57 EXPECT_FALSE(icons.ContainsPath("foo")); 57 EXPECT_FALSE(icons.ContainsPath("foo"));
58 58
59 icons.Add(extension_misc::EXTENSION_ICON_BITTY, "foo"); 59 icons.Add(extension_misc::EXTENSION_ICON_BITTY, "foo");
60 icons.Add(extension_misc::EXTENSION_ICON_GIGANTOR, "bar"); 60 icons.Add(extension_misc::EXTENSION_ICON_GIGANTOR, "bar");
61 61
62 EXPECT_TRUE(icons.ContainsPath("foo")); 62 EXPECT_TRUE(icons.ContainsPath("foo"));
63 EXPECT_TRUE(icons.ContainsPath("bar")); 63 EXPECT_TRUE(icons.ContainsPath("bar"));
64 EXPECT_FALSE(icons.ContainsPath("baz")); 64 EXPECT_FALSE(icons.ContainsPath("baz"));
65 EXPECT_FALSE(icons.ContainsPath(std::string())); 65 EXPECT_FALSE(icons.ContainsPath(std::string()));
66 66
67 icons.Clear(); 67 icons.Clear();
68 EXPECT_FALSE(icons.ContainsPath("foo")); 68 EXPECT_FALSE(icons.ContainsPath("foo"));
69 } 69 }
70 70
71 TEST(ExtensionIconSet, FindSize) { 71 TEST(ExtensionIconSetTest, FindSize) {
72 ExtensionIconSet icons; 72 ExtensionIconSet icons;
73 EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID, 73 EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID,
74 icons.GetIconSizeFromPath("foo")); 74 icons.GetIconSizeFromPath("foo"));
75 75
76 icons.Add(extension_misc::EXTENSION_ICON_BITTY, "foo"); 76 icons.Add(extension_misc::EXTENSION_ICON_BITTY, "foo");
77 icons.Add(extension_misc::EXTENSION_ICON_GIGANTOR, "bar"); 77 icons.Add(extension_misc::EXTENSION_ICON_GIGANTOR, "bar");
78 78
79 EXPECT_EQ(extension_misc::EXTENSION_ICON_BITTY, 79 EXPECT_EQ(extension_misc::EXTENSION_ICON_BITTY,
80 icons.GetIconSizeFromPath("foo")); 80 icons.GetIconSizeFromPath("foo"));
81 EXPECT_EQ(extension_misc::EXTENSION_ICON_GIGANTOR, 81 EXPECT_EQ(extension_misc::EXTENSION_ICON_GIGANTOR,
82 icons.GetIconSizeFromPath("bar")); 82 icons.GetIconSizeFromPath("bar"));
83 EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID, 83 EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID,
84 icons.GetIconSizeFromPath("baz")); 84 icons.GetIconSizeFromPath("baz"));
85 EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID, 85 EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID,
86 icons.GetIconSizeFromPath(std::string())); 86 icons.GetIconSizeFromPath(std::string()));
87 87
88 icons.Clear(); 88 icons.Clear();
89 EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID, 89 EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID,
90 icons.GetIconSizeFromPath("foo")); 90 icons.GetIconSizeFromPath("foo"));
91 } 91 }
92 92
93 } // namespace 93 } // namespace
OLDNEW
« no previous file with comments | « extensions/common/extension_icon_set.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698