Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: extensions/common/extension_icon_set.h

Issue 2626923002: Make ExtensionIconSet::ContainsPath use StringPiece. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/BUILD.gn ('k') | extensions/common/extension_icon_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension_icon_set.h
diff --git a/extensions/common/extension_icon_set.h b/extensions/common/extension_icon_set.h
index 91ce0f51646280ea5bb2f5414650fdc3e5979490..80d0a34081b67b9322fcff1c406e6583f1be5270 100644
--- a/extensions/common/extension_icon_set.h
+++ b/extensions/common/extension_icon_set.h
@@ -9,6 +9,8 @@
#include <set>
#include <string>
+#include "base/strings/string_piece.h"
+
namespace base {
class FilePath;
}
@@ -46,10 +48,10 @@ class ExtensionIconSet {
const std::string& Get(int size, MatchType match_type) const;
// Returns true iff the set contains the specified path.
- bool ContainsPath(const std::string& path) const;
+ bool ContainsPath(base::StringPiece path) const;
// Returns icon size if the set contains the specified path or 0 if not found.
- int GetIconSizeFromPath(const std::string& path) const;
+ int GetIconSizeFromPath(base::StringPiece path) const;
// Add the paths of all icons in this set into |paths|, handling the
// conversion of (string) -> (base::FilePath). Note that these paths are not
« no previous file with comments | « extensions/common/BUILD.gn ('k') | extensions/common/extension_icon_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698