Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2626423004: Remove all //blimp code. (Closed)

Created:
3 years, 11 months ago by nyquist
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all //blimp code. This CL removes all the code and build setup from //blimp and updates related build, config and source code to not care about blimp anymore. This does not update //cc, //content, //services, //ui or third_party DEPS. TBR=brettw@chromium.org BUG=677556 Review-Url: https://codereview.chromium.org/2626423004 Cr-Commit-Position: refs/heads/master@{#444465} Committed: https://chromium.googlesource.com/chromium/src/+/7ab5fc81962a872e9dae8c54493360bac7d3d69d

Patch Set 1 #

Patch Set 2 : merge origin/master #

Patch Set 3 : One last(?) `git merge` for good measure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5201 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M BUILD.gn View 1 1 chunk +0 lines, -7 lines 0 comments Download
M WATCHLISTS View 2 chunks +0 lines, -18 lines 0 comments Download
D blimp/BUILD.gn View 1 chunk +0 lines, -43 lines 0 comments Download
D blimp/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D blimp/OWNERS View 1 chunk +0 lines, -7 lines 0 comments Download
D blimp/PRESUBMIT.py View 1 chunk +0 lines, -57 lines 0 comments Download
D blimp/README.md View 1 chunk +0 lines, -25 lines 0 comments Download
D blimp/common/BUILD.gn View 1 chunk +0 lines, -92 lines 0 comments Download
D blimp/common/DEPS View 1 chunk +0 lines, -12 lines 0 comments Download
D blimp/common/blimp_common_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/common/blob_cache/blob_cache.h View 1 chunk +0 lines, -45 lines 0 comments Download
D blimp/common/blob_cache/id_util.h View 1 chunk +0 lines, -31 lines 0 comments Download
D blimp/common/blob_cache/id_util.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D blimp/common/blob_cache/id_util_unittest.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D blimp/common/blob_cache/in_memory_blob_cache.h View 1 chunk +0 lines, -40 lines 0 comments Download
D blimp/common/blob_cache/in_memory_blob_cache.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D blimp/common/blob_cache/in_memory_blob_cache_unittest.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D blimp/common/blob_cache/mock_blob_cache.h View 1 chunk +0 lines, -31 lines 0 comments Download
D blimp/common/blob_cache/mock_blob_cache.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D blimp/common/blob_cache/test_util.h View 1 chunk +0 lines, -18 lines 0 comments Download
D blimp/common/blob_cache/test_util.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D blimp/common/compositor/reference_tracker.h View 1 chunk +0 lines, -63 lines 0 comments Download
D blimp/common/compositor/reference_tracker.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D blimp/common/compositor/reference_tracker_unittest.cc View 1 chunk +0 lines, -199 lines 0 comments Download
D blimp/common/create_blimp_message.h View 1 chunk +0 lines, -88 lines 0 comments Download
D blimp/common/create_blimp_message.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D blimp/common/create_blimp_message_unittest.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D blimp/common/get_client_auth_token.h View 1 chunk +0 lines, -23 lines 0 comments Download
D blimp/common/get_client_auth_token.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D blimp/common/logging.h View 1 chunk +0 lines, -25 lines 0 comments Download
D blimp/common/logging.cc View 1 chunk +0 lines, -410 lines 0 comments Download
D blimp/common/logging_unittest.cc View 1 chunk +0 lines, -321 lines 0 comments Download
D blimp/common/mandatory_callback.h View 1 chunk +0 lines, -118 lines 0 comments Download
D blimp/common/mandatory_callback_unittest.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D blimp/common/proto/BUILD.gn View 1 chunk +0 lines, -52 lines 0 comments Download
D blimp/common/proto/blimp_message.proto View 1 chunk +0 lines, -70 lines 0 comments Download
D blimp/common/proto/blimp_proto_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/common/proto/blob_cache.proto View 1 chunk +0 lines, -19 lines 0 comments Download
D blimp/common/proto/blob_channel.proto View 1 chunk +0 lines, -21 lines 0 comments Download
D blimp/common/proto/common.proto View 1 chunk +0 lines, -13 lines 0 comments Download
D blimp/common/proto/compositor.proto View 1 chunk +0 lines, -21 lines 0 comments Download
D blimp/common/proto/geolocation.proto View 1 chunk +0 lines, -59 lines 0 comments Download
D blimp/common/proto/helium.proto View 1 chunk +0 lines, -60 lines 0 comments Download
D blimp/common/proto/ime.proto View 1 chunk +0 lines, -52 lines 0 comments Download
D blimp/common/proto/input.proto View 1 chunk +0 lines, -116 lines 0 comments Download
D blimp/common/proto/navigation.proto View 1 chunk +0 lines, -65 lines 0 comments Download
D blimp/common/proto/protocol_control.proto View 1 chunk +0 lines, -41 lines 0 comments Download
D blimp/common/proto/render_widget.proto View 1 chunk +0 lines, -24 lines 0 comments Download
D blimp/common/proto/settings.proto View 1 chunk +0 lines, -23 lines 0 comments Download
D blimp/common/proto/tab_control.proto View 1 chunk +0 lines, -33 lines 0 comments Download
D blimp/common/protocol_version.h.version View 1 chunk +0 lines, -15 lines 0 comments Download
D blimp/common/switches.h View 1 chunk +0 lines, -17 lines 0 comments Download
D blimp/common/switches.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D blimp/docs/build.md View 1 chunk +0 lines, -104 lines 0 comments Download
D blimp/docs/container.md View 1 chunk +0 lines, -100 lines 0 comments Download
D blimp/docs/fonts.md View 1 chunk +0 lines, -32 lines 0 comments Download
D blimp/docs/markdown.md View 1 chunk +0 lines, -30 lines 0 comments Download
D blimp/docs/running.md View 1 chunk +0 lines, -274 lines 0 comments Download
D blimp/docs/test.md View 1 chunk +0 lines, -55 lines 0 comments Download
D blimp/test/BUILD.gn View 1 chunk +0 lines, -44 lines 0 comments Download
D blimp/test/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D blimp/test/data/input.html View 1 chunk +0 lines, -26 lines 0 comments Download
D blimp/test/data/page1.html View 1 chunk +0 lines, -2 lines 0 comments Download
D blimp/test/data/page2.html View 1 chunk +0 lines, -2 lines 0 comments Download
D blimp/test/data/test_client_token View 1 chunk +0 lines, -1 line 0 comments Download
D blimp/test/fake_engine/BUILD.gn View 1 chunk +0 lines, -52 lines 0 comments Download
D blimp/test/fake_engine/fake_engine.h View 1 chunk +0 lines, -61 lines 0 comments Download
D blimp/test/fake_engine/fake_engine.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D blimp/test/fake_engine/fake_engine_app_tests.cc View 1 chunk +0 lines, -214 lines 0 comments Download
D blimp/test/fake_engine/fake_engine_main.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D blimp/test/fake_engine/proto/BUILD.gn View 1 chunk +0 lines, -52 lines 0 comments Download
D blimp/test/fake_engine/proto/engine.proto View 1 chunk +0 lines, -33 lines 0 comments Download
D blimp/test/fake_engine/proto/lifetime.proto View 1 chunk +0 lines, -21 lines 0 comments Download
D blimp/test/fake_engine/proto/logging.proto View 1 chunk +0 lines, -22 lines 0 comments Download
D blimp/test/impaired_network/test_runner.py View 1 chunk +0 lines, -132 lines 0 comments Download
D blimp/test/run_all_unittests.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/test/support/compositor/picture_cache_test_support.h View 1 chunk +0 lines, -44 lines 0 comments Download
D blimp/test/support/compositor/picture_cache_test_support.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D blimp/tools/Dockerfile.base View 1 chunk +0 lines, -18 lines 0 comments Download
D blimp/tools/PRESUBMIT.py View 1 chunk +0 lines, -42 lines 0 comments Download
D blimp/tools/create-bundle.py View 1 chunk +0 lines, -96 lines 0 comments Download
D blimp/tools/engine-manifest-blacklist.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D blimp/tools/fake_web/data/square.html View 1 chunk +0 lines, -62 lines 0 comments Download
D blimp/tools/fake_web/server.py View 1 chunk +0 lines, -49 lines 0 comments Download
D blimp/tools/generate-target-manifest.py View 1 chunk +0 lines, -57 lines 0 comments Download
D blimp/tools/pylintrc View 1 chunk +0 lines, -23 lines 0 comments Download
D blimp/tools/tests-manifest-blacklist.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M build/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D build/android/adb_blimp_command_line View 1 chunk +0 lines, -17 lines 0 comments Download
D build/android/adb_gdb_blimp_client View 1 chunk +0 lines, -16 lines 0 comments Download
D build/android/adb_kill_blimp_client View 1 chunk +0 lines, -24 lines 0 comments Download
D build/android/adb_run_blimp_client View 1 chunk +0 lines, -12 lines 0 comments Download
M build/android/lint/suppressions.xml View 5 chunks +0 lines, -24 lines 0 comments Download
D build/args/blimp_client.gn View 1 chunk +0 lines, -1 line 0 comments Download
D build/args/blimp_engine.gn View 1 chunk +0 lines, -1 line 0 comments Download
D build/args/blimp_linux_client.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D build/args/bots/chromium.fyi/blimp_client_rel.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D build/args/bots/chromium.fyi/blimp_engine_rel.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D build/args/bots/chromium.linux/blimp_linux_dbg.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D build/args/bots/official.android/blimp-engine.gn View 1 chunk +0 lines, -16 lines 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M components/metrics/metrics_log.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/android/checkstyle/suppressions.xml View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/eclipse/.classpath View 1 chunk +0 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (14 generated)
nyquist
kmarshall: PTAL This CL depends on the build infrastructure already having been removed, which dpranke@ ...
3 years, 11 months ago (2017-01-13 23:08:41 UTC) #2
nyquist
Note: This CL requires deleting blimp buildbots to have happened before landing. asvitkine: PTAL //components/metrics ...
3 years, 11 months ago (2017-01-13 23:15:43 UTC) #4
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-14 00:27:48 UTC) #5
Alexei Svitkine (slow)
components/metrics lgtm
3 years, 11 months ago (2017-01-16 20:12:58 UTC) #6
Nico
tools/gritsettings/translation_expectations.pyl lgtm
3 years, 11 months ago (2017-01-17 12:54:04 UTC) #7
Kevin M
lgtm Time to give it a proper Viking funeral. *launches flaming arrow at //blimp/* *//blimp/ ...
3 years, 11 months ago (2017-01-17 17:52:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626423004/40001
3 years, 11 months ago (2017-01-18 19:36:51 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/344468)
3 years, 11 months ago (2017-01-18 19:50:00 UTC) #17
nyquist
brettw: TBR for deleting //blimp. Since //blimp/OWNERS is deleted in the same CL that deletes ...
3 years, 11 months ago (2017-01-18 19:53:05 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626423004/40001
3 years, 11 months ago (2017-01-18 19:54:00 UTC) #22
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 20:38:22 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7ab5fc81962a872e9dae8c544933...

Powered by Google App Engine
This is Rietveld 408576698