Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2626423004: Remove all //blimp code. (Closed)
Patch Set: One last(?) `git merge` for good measure. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/adb_run_blimp_client ('k') | build/args/blimp_client.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 21 matching lines...) Expand all
32 <issue id="ButtonOrder" severity="Error"> 32 <issue id="ButtonOrder" severity="Error">
33 <ignore regexp="chrome/android/java/res/layout/homepage_editor.xml"/> 33 <ignore regexp="chrome/android/java/res/layout/homepage_editor.xml"/>
34 </issue> 34 </issue>
35 <issue id="ButtonStyle" severity="Error"> 35 <issue id="ButtonStyle" severity="Error">
36 <ignore regexp="remoting/android/host/res/layout/main.xml"/> 36 <ignore regexp="remoting/android/host/res/layout/main.xml"/>
37 </issue> 37 </issue>
38 <issue id="CommitPrefEdits"> 38 <issue id="CommitPrefEdits">
39 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali dation/ticl/android2/channel/AndroidChannelPreferences.java"/> 39 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali dation/ticl/android2/channel/AndroidChannelPreferences.java"/>
40 </issue> 40 </issue>
41 <issue id="ContentDescription" severity="Error"> 41 <issue id="ContentDescription" severity="Error">
42 <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml"/>
43 <ignore regexp="chromecast/internal"/> 42 <ignore regexp="chromecast/internal"/>
44 </issue> 43 </issue>
45 <issue id="DefaultLocale"> 44 <issue id="DefaultLocale">
46 <ignore regexp="clank"/> 45 <ignore regexp="clank"/>
47 <ignore regexp="com/android/tv"/> 46 <ignore regexp="com/android/tv"/>
48 <ignore regexp="org/chromium/chrome/browser/payments/PaymentRequestMetricsTe st.class"/> 47 <ignore regexp="org/chromium/chrome/browser/payments/PaymentRequestMetricsTe st.class"/>
49 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbChooserPr eferences"/> 48 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbChooserPr eferences"/>
50 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbDevicePre ferences"/> 49 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbDevicePre ferences"/>
51 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali dation/external/client/contrib/AndroidListenerState.java"/> 50 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali dation/external/client/contrib/AndroidListenerState.java"/>
52 </issue> 51 </issue>
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 IDS_ACCESSIBILITY_TOOLBAR_BTN_TABSWITCHER_TOGGLE (http://crbug.com/635677) 169 IDS_ACCESSIBILITY_TOOLBAR_BTN_TABSWITCHER_TOGGLE (http://crbug.com/635677)
171 --> 170 -->
172 <issue id="MissingQuantity"> 171 <issue id="MissingQuantity">
173 <ignore regexp="android_chrome_strings.xml"/> 172 <ignore regexp="android_chrome_strings.xml"/>
174 </issue> 173 </issue>
175 <issue id="MissingRegistered" severity="ignore"/> 174 <issue id="MissingRegistered" severity="ignore"/>
176 <issue id="MissingSuperCall" severity="Error"> 175 <issue id="MissingSuperCall" severity="Error">
177 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/widget/s election/SelectionToolbar.java"/> 176 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/widget/s election/SelectionToolbar.java"/>
178 </issue> 177 </issue>
179 <issue id="MissingTranslation"> 178 <issue id="MissingTranslation">
180 <ignore regexp="blimp/client/app/android/java/res/values/arrays.xml"/>
181 <ignore regexp="blimp/client/core/resources/android/java/res/values/arrays.x ml" />
182 <!-- http://crbug.com/450548 --> 179 <!-- http://crbug.com/450548 -->
183 <ignore regexp="chromecast/internal"/> 180 <ignore regexp="chromecast/internal"/>
184 <ignore regexp="restriction_values.xml.*"/> 181 <ignore regexp="restriction_values.xml.*"/>
185 </issue> 182 </issue>
186 <issue id="MissingVersion"> 183 <issue id="MissingVersion">
187 <ignore path="AndroidManifest.xml"/> 184 <ignore path="AndroidManifest.xml"/>
188 </issue> 185 </issue>
189 <issue id="NewApi"> 186 <issue id="NewApi">
190 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/> 187 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/>
191 <ignore regexp="chrome/android/java/res/drawable/downloads_big.xml"/> 188 <ignore regexp="chrome/android/java/res/drawable/downloads_big.xml"/>
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 <issue id="UnusedResources"> 285 <issue id="UnusedResources">
289 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits.html"/> 286 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits.html"/>
290 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_css.css"/> 287 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_css.css"/>
291 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_js.js"/> 288 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/credits_js.js"/>
292 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/main.css"/> 289 <ignore regexp="PRODUCT_DIR/gen/remoting/android/remoting_android_raw_resour ces/res/raw/main.css"/>
293 <ignore regexp="android_ui_strings.xml"/> 290 <ignore regexp="android_ui_strings.xml"/>
294 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/> 291 <ignore regexp="android_webview/java/res/drawable-hdpi/ic_play_circle_outlin e_black_48dp.png"/>
295 <ignore regexp="android_webview/test/shell/res/raw/resource_file.html"/> 292 <ignore regexp="android_webview/test/shell/res/raw/resource_file.html"/>
296 <ignore regexp="android_webview/test/shell/res/raw/resource_icon.png"/> 293 <ignore regexp="android_webview/test/shell/res/raw/resource_icon.png"/>
297 <ignore regexp="android_webview/tools/automated_ui_tests/java/res/"/> 294 <ignore regexp="android_webview/tools/automated_ui_tests/java/res/"/>
298 <ignore regexp="blimp/client/app/android/java/res/drawable/dotted_line.xml"/ >
299 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/btn_menu.png "/>
300 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/btn_reload.p ng"/>
301 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/textbox.9.pn g"/>
302 <ignore regexp="blimp/client/app/android/java/res/drawable-hdpi/web_input_ba ckground.9.png"/>
303 <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml"/>
304 <ignore regexp="blimp/client/app/android/java/res/layout/debug_stats_overlay .xml"/>
305 <ignore regexp="blimp/client/app/android/java/res/layout/text_input_popup.xm l"/>
306 <ignore regexp="blimp/client/app/android/java/res/layout/toolbar_popup_item. xml"/>
307 <ignore regexp="blimp/client/app/android/java/res/layout/web_input_bottom_pa nel.xml"/>
308 <ignore regexp="blimp/client/app/android/java/res/mipmap-hdpi/app_icon.png"/ >
309 <ignore regexp="blimp/client/app/android/java/res/values/arrays.xml"/>
310 <ignore regexp="blimp/client/app/android/java/res/values/colors.xml"/>
311 <ignore regexp="blimp/client/app/android/java/res/values/dimens.xml"/>
312 <ignore regexp="blimp/client/app/android/java/res/xml/about_blimp_preference s.xml"/>
313 <ignore regexp="blimp/client/app/android/java/res/xml/blimp_preferences.xml" />
314 <ignore regexp="blimp/client/core/resources/android/java/res/*" />
315 <!-- TODO(crbug.com/635567): Fix this properly. --> 295 <!-- TODO(crbug.com/635567): Fix this properly. -->
316 <ignore regexp="chrome/android/java/res/drawable-hdpi/*"/> 296 <ignore regexp="chrome/android/java/res/drawable-hdpi/*"/>
317 <ignore regexp="chrome/android/java/res/drawable-hdpi/bubble_white.9.png"/> 297 <ignore regexp="chrome/android/java/res/drawable-hdpi/bubble_white.9.png"/>
318 <ignore regexp="chrome/android/java/res/drawable-hdpi/cvc_icon.png"/> 298 <ignore regexp="chrome/android/java/res/drawable-hdpi/cvc_icon.png"/>
319 <ignore regexp="chrome/android/java/res/drawable-hdpi/cvc_icon_amex.png"/> 299 <ignore regexp="chrome/android/java/res/drawable-hdpi/cvc_icon_amex.png"/>
320 <ignore regexp="chrome/android/java/res/drawable-hdpi/ic_folder_white_24dp.p ng"/> 300 <ignore regexp="chrome/android/java/res/drawable-hdpi/ic_folder_white_24dp.p ng"/>
321 <ignore regexp="chrome/android/java/res/drawable-hdpi/ic_settings.png"/> 301 <ignore regexp="chrome/android/java/res/drawable-hdpi/ic_settings.png"/>
322 <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_3d_blocked.png "/> 302 <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_3d_blocked.png "/>
323 <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_autofill_cc.pn g"/> 303 <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_autofill_cc.pn g"/>
324 <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_blocked_popups .png"/> 304 <ignore regexp="chrome/android/java/res/drawable-hdpi/infobar_blocked_popups .png"/>
(...skipping 25 matching lines...) Expand all
350 TODO(estevenson) remove this and the conditional inclusion in 330 TODO(estevenson) remove this and the conditional inclusion in
351 AndroidManifest.xml after rolling to SDK 24. 331 AndroidManifest.xml after rolling to SDK 24.
352 --> 332 -->
353 <ignore regexp="chrome/android/java/res/xml/network_security_config.xml"/> 333 <ignore regexp="chrome/android/java/res/xml/network_security_config.xml"/>
354 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml"/> 334 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml"/>
355 <ignore regexp="chromecast/internal"/> 335 <ignore regexp="chromecast/internal"/>
356 <ignore regexp="clank"/> 336 <ignore regexp="clank"/>
357 <ignore regexp="content/shell/android/java/res/mipmap-hdpi/app_icon.png"/> 337 <ignore regexp="content/shell/android/java/res/mipmap-hdpi/app_icon.png"/>
358 <ignore regexp="gen/android_webview/locale_paks.resources.zip/*"/> 338 <ignore regexp="gen/android_webview/locale_paks.resources.zip/*"/>
359 <ignore regexp="gen/android_webview/strings_grd.resources.zip/values/android _webview_strings.xml"/> 339 <ignore regexp="gen/android_webview/strings_grd.resources.zip/values/android _webview_strings.xml"/>
360 <ignore regexp="gen/blimp/client/app/blimp_strings_grd.resources.zip/values/ android_blimp_strings.xml" />
361 <ignore regexp="gen/blimp/client/core/resources/strings_grd.resources.zip/va lues/blimp_strings.xml" />
362 <ignore regexp="gen/components/strings/components_strings_grd.resources.zip/ values.*/components_strings.xml"/> 340 <ignore regexp="gen/components/strings/components_strings_grd.resources.zip/ values.*/components_strings.xml"/>
363 <ignore regexp="gen/remoting/resources/strings_java.resources.zip/values/rem oting_strings.xml"/> 341 <ignore regexp="gen/remoting/resources/strings_java.resources.zip/values/rem oting_strings.xml"/>
364 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_backspace.png"/> 342 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_backspace.png"/>
365 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_cardboard.png"/> 343 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_cardboard.png"/>
366 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_voice_input.png"/ > 344 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_voice_input.png"/ >
367 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_in.png"/> 345 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_in.png"/>
368 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_out.png"/> 346 <ignore regexp="remoting/android/java/res/drawable-hdpi/ic_zoom_out.png"/>
369 <ignore regexp="remoting/android/java/res/layout/navigation_list_item.xml"/> 347 <ignore regexp="remoting/android/java/res/layout/navigation_list_item.xml"/>
370 <ignore regexp="remoting/android/java/res/mipmap-hdpi/logo_remote_desktop_la uncher.png"/> 348 <ignore regexp="remoting/android/java/res/mipmap-hdpi/logo_remote_desktop_la uncher.png"/>
371 <ignore regexp="remoting/android/java/res/values-v17/styles.xml"/> 349 <ignore regexp="remoting/android/java/res/values-v17/styles.xml"/>
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 <issue id="UselessParent"> 436 <issue id="UselessParent">
459 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/> 437 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/>
460 <ignore regexp="chrome/android/java/res/layout/data_reduction_promo_screen.x ml"/> 438 <ignore regexp="chrome/android/java/res/layout/data_reduction_promo_screen.x ml"/>
461 <ignore regexp="chromecast/internal"/> 439 <ignore regexp="chromecast/internal"/>
462 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml"/> 440 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml"/>
463 </issue> 441 </issue>
464 <issue id="UsesMinSdkAttributes" severity="Error"> 442 <issue id="UsesMinSdkAttributes" severity="Error">
465 <ignore regexp="AndroidManifest.xml"/> 443 <ignore regexp="AndroidManifest.xml"/>
466 </issue> 444 </issue>
467 <issue id="ValidFragment" severity="Error"> 445 <issue id="ValidFragment" severity="Error">
468 <ignore regexp="blimp/client/app/android/javatests/src/org/chromium/blimp/co re/settings/BlimpPreferencesTest.java"/>
469 <ignore regexp="blimp/client/app/android/javatests/src/org/chromium/blimp/co re/settings/MockPreferences.java"/>
470 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java"/> 446 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java"/>
471 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java"/> 447 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java"/>
472 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java"/> 448 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java"/>
473 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java"/> 449 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java"/>
474 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/> 450 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/>
475 </issue> 451 </issue>
476 <issue id="ViewConstructor" severity="ignore"/> 452 <issue id="ViewConstructor" severity="ignore"/>
477 <issue id="WrongCall" severity="ignore"/> 453 <issue id="WrongCall" severity="ignore"/>
478 <issue id="WrongConstant"> 454 <issue id="WrongConstant">
479 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> 455 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/>
480 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> 456 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/>
481 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> 457 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/>
482 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/> 458 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java"/>
483 </issue> 459 </issue>
484 </lint> 460 </lint>
OLDNEW
« no previous file with comments | « build/android/adb_run_blimp_client ('k') | build/args/blimp_client.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698