[M56] Have a list of pending checks instead of pending clients

[M56] Have a list of pending checks instead of pending clients

Merges http://crrev.com/2616653002 to M56.
[Merge CL 4/n]

Note: This CL is not an exact merge of http://crrev.com/2616653002
because the master branch had deviated from the M56 branch by the time
this original CL was submitted.

Here's the sequence of events:
1. M56 is branched off master.
2. http://crrev.com/2619873002 componentizes SBRT, thereby splitting it
up into chrome/browser/loader/safe_browsing_resource_throttle.h/cc and
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
3. I submitted http://crrev.com/2616653002, which is that CL I am trying
to merge here.
4. http://crrev.com/2623733002 renames
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc to
components/safe_browsing/base_resource_throttle.h/cc

That's the reason:
1. I need to backport those changes to
chrome/browser/loader/safe_browsing_resource_throttle.h/cc manually AND
2. components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
doesn't exist any longer.

NOTRY=true
NOPRESUBMIT=true

BUG=660293
Review-Url: https://codereview.chromium.org/2626153003
Cr-Commit-Position: refs/branch-heads/2924@{#755}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/5d27422f373f65c90c3baa504a5b77bebeb37bcf

[vakh (use Gerrit instead), 2017-01-12 18:05:15]

vakh@chromium.org changed reviewers:
+ csharrison@chromium.org, nparker@chromium.org

[vakh (use Gerrit instead), 2017-01-12 18:08:14]

On 2017/01/12 18:05:16, vakh (Varun Khaneja) wrote:

Please note that this CL is not an exact copy of http://crrev.com/2616653002

CL 2616653002 modified base_safe_browsing_resource_throttle.* since SBRT had
been split up on the master branch by then. However, on M56 branch, that split
does not exist so I had to make those changes to
safe_browsing_resource_throttle.*

This CL is essentially the same as the second last patch there:
http://crrev.com/2616653002/#ps200001

[Charlie Harrison, 2017-01-12 18:09:24]

I am very confused, in the original CL you ended up moving the logic to
base_safe_browsing_resource_throttle.cc. Can you explain that?

[Charlie Harrison, 2017-01-12 18:11:04]

On 2017/01/12 18:08:14, vakh (Varun Khaneja) wrote:
> On 2017/01/12 18:05:16, vakh (Varun Khaneja) wrote:
> 
> Please note that this CL is not an exact copy of http://crrev.com/2616653002
> 
> CL 2616653002 modified base_safe_browsing_resource_throttle.* since SBRT had
> been split up on the master branch by then. However, on M56 branch, that split
> does not exist so I had to make those changes to
> safe_browsing_resource_throttle.*
> 
> This CL is essentially the same as the second last patch there:
> http://crrev.com/2616653002/#ps200001

Huh, LGTM but I'm still confused because I can't find the base_ resource
throttle in codereview atm.

[vakh (use Gerrit instead), 2017-01-12 18:15:57]

On 2017/01/12 18:11:04, Charlie Harrison wrote:
> On 2017/01/12 18:08:14, vakh (Varun Khaneja) wrote:
> > On 2017/01/12 18:05:16, vakh (Varun Khaneja) wrote:
> > 
> > Please note that this CL is not an exact copy of http://crrev.com/2616653002
> > 
> > CL 2616653002 modified base_safe_browsing_resource_throttle.* since SBRT had
> > been split up on the master branch by then. However, on M56 branch, that
split
> > does not exist so I had to make those changes to
> > safe_browsing_resource_throttle.*
> > 
> > This CL is essentially the same as the second last patch there:
> > http://crrev.com/2616653002/#ps200001
> 
> Huh, LGTM but I'm still confused because I can't find the base_ resource
> throttle in codereview atm.

Sorry for the confusion. I should have made this clear in the description.

Here's the sequence of events:
1. M56 is branched off master.
2. http://crrev.com/2619873002 componentizes SBRT, thereby splitting it up into
chrome/browser/loader/safe_browsing_resource_throttle.h/cc and
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
3. I submit http://crrev.com/2626153003, which is that CL I am trying to merge
here.
4. http://crrev.com/2623733002 renames
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc to
components/safe_browsing/base_resource_throttle.h/cc

That's the reason:
1. I need to backport those changes to
chrome/browser/loader/safe_browsing_resource_throttle.h/cc manually AND
2. components/safe_browsing/base_safe_browsing_resource_throttle.h/cc doesn't
exist any longer.

[vakh (use Gerrit instead), 2017-01-12 18:19:09]

Description was changed from

==========
[M56] Have a list of pending checks instead of pending clients

Merges http://crrev.com/2616653002 to M56.
[Merge CL 4/n]

BUG=660293
==========

to

==========
[M56] Have a list of pending checks instead of pending clients

Merges http://crrev.com/2616653002 to M56.
[Merge CL 4/n]

Note: This CL is not an exact merge of http://crrev.com/2616653002
because the master branch had deviated from the M56 branch by the time
this original CL was submitted.

Here's the sequence of events:
1. M56 is branched off master.
2. http://crrev.com/2619873002 componentizes SBRT, thereby splitting it
up into chrome/browser/loader/safe_browsing_resource_throttle.h/cc and
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
3. I submitted http://crrev.com/2626153003, which is that CL I am trying
to merge here.
4. http://crrev.com/2623733002 renames
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc to
components/safe_browsing/base_resource_throttle.h/cc

That's the reason:
1. I need to backport those changes to
chrome/browser/loader/safe_browsing_resource_throttle.h/cc manually AND
2. components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
doesn't exist any longer.

BUG=660293
==========

[Charlie Harrison, 2017-01-12 18:20:29]

Thank you, that clears everything up.

[vakh (use Gerrit instead), 2017-01-12 18:21:04]

Description was changed from

==========
[M56] Have a list of pending checks instead of pending clients

Merges http://crrev.com/2616653002 to M56.
[Merge CL 4/n]

Note: This CL is not an exact merge of http://crrev.com/2616653002
because the master branch had deviated from the M56 branch by the time
this original CL was submitted.

Here's the sequence of events:
1. M56 is branched off master.
2. http://crrev.com/2619873002 componentizes SBRT, thereby splitting it
up into chrome/browser/loader/safe_browsing_resource_throttle.h/cc and
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
3. I submitted http://crrev.com/2626153003, which is that CL I am trying
to merge here.
4. http://crrev.com/2623733002 renames
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc to
components/safe_browsing/base_resource_throttle.h/cc

That's the reason:
1. I need to backport those changes to
chrome/browser/loader/safe_browsing_resource_throttle.h/cc manually AND
2. components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
doesn't exist any longer.

BUG=660293
==========

to

==========
[M56] Have a list of pending checks instead of pending clients

Merges http://crrev.com/2616653002 to M56.
[Merge CL 4/n]

Note: This CL is not an exact merge of http://crrev.com/2616653002
because the master branch had deviated from the M56 branch by the time
this original CL was submitted.

Here's the sequence of events:
1. M56 is branched off master.
2. http://crrev.com/2619873002 componentizes SBRT, thereby splitting it
up into chrome/browser/loader/safe_browsing_resource_throttle.h/cc and
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
3. I submitted http://crrev.com/2616653002, which is that CL I am trying
to merge here.
4. http://crrev.com/2623733002 renames
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc to
components/safe_browsing/base_resource_throttle.h/cc

That's the reason:
1. I need to backport those changes to
chrome/browser/loader/safe_browsing_resource_throttle.h/cc manually AND
2. components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
doesn't exist any longer.

BUG=660293
==========

[vakh (use Gerrit instead), 2017-01-12 20:00:05]

Description was changed from

==========
[M56] Have a list of pending checks instead of pending clients

Merges http://crrev.com/2616653002 to M56.
[Merge CL 4/n]

Note: This CL is not an exact merge of http://crrev.com/2616653002
because the master branch had deviated from the M56 branch by the time
this original CL was submitted.

Here's the sequence of events:
1. M56 is branched off master.
2. http://crrev.com/2619873002 componentizes SBRT, thereby splitting it
up into chrome/browser/loader/safe_browsing_resource_throttle.h/cc and
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
3. I submitted http://crrev.com/2616653002, which is that CL I am trying
to merge here.
4. http://crrev.com/2623733002 renames
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc to
components/safe_browsing/base_resource_throttle.h/cc

That's the reason:
1. I need to backport those changes to
chrome/browser/loader/safe_browsing_resource_throttle.h/cc manually AND
2. components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
doesn't exist any longer.

BUG=660293
==========

to

==========
[M56] Have a list of pending checks instead of pending clients

Merges http://crrev.com/2616653002 to M56.
[Merge CL 4/n]

Note: This CL is not an exact merge of http://crrev.com/2616653002
because the master branch had deviated from the M56 branch by the time
this original CL was submitted.

Here's the sequence of events:
1. M56 is branched off master.
2. http://crrev.com/2619873002 componentizes SBRT, thereby splitting it
up into chrome/browser/loader/safe_browsing_resource_throttle.h/cc and
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
3. I submitted http://crrev.com/2616653002, which is that CL I am trying
to merge here.
4. http://crrev.com/2623733002 renames
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc to
components/safe_browsing/base_resource_throttle.h/cc

That's the reason:
1. I need to backport those changes to
chrome/browser/loader/safe_browsing_resource_throttle.h/cc manually AND
2. components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
doesn't exist any longer.

NOTRY=true
NOPRESUBMIT=true

BUG=660293
==========

[Nathan Parker, 2017-01-12 23:29:38]

lgtm

[vakh (use Gerrit instead), 2017-01-13 03:14:03]

The CQ bit was checked by vakh@chromium.org

[commit-bot: I haz the power, 2017-01-13 03:14:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 03:17:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484277243720680, "parent_rev":
"881bcc9c0073e39ccd53444b19fb72a4def29a52", "commit_rev":
"5d27422f373f65c90c3baa504a5b77bebeb37bcf"}

[commit-bot: I haz the power, 2017-01-13 03:18:07]

Description was changed from

==========
[M56] Have a list of pending checks instead of pending clients

Merges http://crrev.com/2616653002 to M56.
[Merge CL 4/n]

Note: This CL is not an exact merge of http://crrev.com/2616653002
because the master branch had deviated from the M56 branch by the time
this original CL was submitted.

Here's the sequence of events:
1. M56 is branched off master.
2. http://crrev.com/2619873002 componentizes SBRT, thereby splitting it
up into chrome/browser/loader/safe_browsing_resource_throttle.h/cc and
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
3. I submitted http://crrev.com/2616653002, which is that CL I am trying
to merge here.
4. http://crrev.com/2623733002 renames
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc to
components/safe_browsing/base_resource_throttle.h/cc

That's the reason:
1. I need to backport those changes to
chrome/browser/loader/safe_browsing_resource_throttle.h/cc manually AND
2. components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
doesn't exist any longer.

NOTRY=true
NOPRESUBMIT=true

BUG=660293
==========

to

==========
[M56] Have a list of pending checks instead of pending clients

Merges http://crrev.com/2616653002 to M56.
[Merge CL 4/n]

Note: This CL is not an exact merge of http://crrev.com/2616653002
because the master branch had deviated from the M56 branch by the time
this original CL was submitted.

Here's the sequence of events:
1. M56 is branched off master.
2. http://crrev.com/2619873002 componentizes SBRT, thereby splitting it
up into chrome/browser/loader/safe_browsing_resource_throttle.h/cc and
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
3. I submitted http://crrev.com/2616653002, which is that CL I am trying
to merge here.
4. http://crrev.com/2623733002 renames
components/safe_browsing/base_safe_browsing_resource_throttle.h/cc to
components/safe_browsing/base_resource_throttle.h/cc

That's the reason:
1. I need to backport those changes to
chrome/browser/loader/safe_browsing_resource_throttle.h/cc manually AND
2. components/safe_browsing/base_safe_browsing_resource_throttle.h/cc
doesn't exist any longer.

NOTRY=true
NOPRESUBMIT=true

BUG=660293

Review-Url: https://codereview.chromium.org/2626153003
Cr-Commit-Position: refs/branch-heads/2924@{#755}
Cr-Branched-From:
3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d27422f373f65c90c3baa504a5b...
==========

[commit-bot: I haz the power, 2017-01-13 03:18:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d27422f373f65c90c3baa504a5b...