Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2629713002: [M56] Add the missing callback to client for CheckResourceUrl (Closed)

Created:
3 years, 11 months ago by vakh (use Gerrit instead)
Modified:
3 years, 11 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, vakh+watch_chromium.org, Scott Hess - ex-Googler
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[M56] Add the missing callback to client for CheckResourceUrl Merges http://crrev.com/2622063002 to M56. NOTRY=true NOPRESUBMIT=true BUG=679906 Review-Url: https://codereview.chromium.org/2629713002 Cr-Commit-Position: refs/branch-heads/2924@{#757} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/e3870de98715fb276dee10831a43efe98a2523ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -37 lines) Patch
M components/safe_browsing_db/v4_local_database_manager.h View 2 chunks +7 lines, -2 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 4 chunks +32 lines, -16 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager_unittest.cc View 8 chunks +61 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
vakh (use Gerrit instead)
3 years, 11 months ago (2017-01-12 22:32:47 UTC) #2
Nathan Parker
lgtm
3 years, 11 months ago (2017-01-12 23:23:23 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2626153003 Patch 1). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-13 03:15:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629713002/1
3 years, 11 months ago (2017-01-13 03:21:32 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 03:22:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3870de98715fb276dee10831a43...

Powered by Google App Engine
This is Rietveld 408576698