Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2629583004: [M56] Test uses fake protocol manager rather than hard-coded urls. (Closed)

Created:
3 years, 11 months ago by vakh (use Gerrit instead)
Modified:
3 years, 11 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, vakh+watch_chromium.org, Scott Hess - ex-Googler
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[M56] Test uses fake protocol manager rather than hard-coded urls. Merges http://crrev.com/2618153002 to M56 (2924). [Merge CL 3/n] NOTRY=true NOPRESUBMIT=true BUG=660293 Review-Url: https://codereview.chromium.org/2629583004 Cr-Commit-Position: refs/branch-heads/2924@{#745} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/57a81dce78cc85edf337701883fd0ad92aceaa0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -34 lines) Patch
M components/safe_browsing_db/v4_local_database_manager_unittest.cc View 4 chunks +59 lines, -34 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
vakh (use Gerrit instead)
3 years, 11 months ago (2017-01-12 17:19:14 UTC) #3
Nathan Parker
lgtm s/stable// in desc
3 years, 11 months ago (2017-01-12 17:21:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629583004/1
3 years, 11 months ago (2017-01-12 19:38:56 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 19:43:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/57a81dce78cc85edf337701883fd...

Powered by Google App Engine
This is Rietveld 408576698