Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2625873005: Add an heuristic for promoting canvases to GPU acceleration (Closed)

Created:
3 years, 11 months ago by Justin Novosad
Modified:
3 years, 11 months ago
Reviewers:
xlai (Olivia)
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, haraken, dglazkov+blink, Rik, f(malita), blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an heuristic for promoting canvases to GPU acceleration This change adds a new condition under which 2D canvases should be promoted to GPU acceleration: if a gpu-accelerated source is drawn to it. There was a pre-existing heuristic for disabling acceleration on the source if the source is a 2D canvas. Promoting the destination, if possible, is usually preferable. This also has benefits when the source is a WebGL canvas or a video. BUG=464835, 524628 Review-Url: https://codereview.chromium.org/2625873005 Cr-Commit-Position: refs/heads/master@{#443923} Committed: https://chromium.googlesource.com/chromium/src/+/41d279a5476937a3981a8413be722d42da0de0d2

Patch Set 1 #

Patch Set 2 : test fix + formatting #

Patch Set 3 : webgl test fix #

Messages

Total messages: 19 (11 generated)
Justin Novosad
PTAL. Note: CL to land after the related benchmark has landed and simmered on the ...
3 years, 11 months ago (2017-01-11 20:43:14 UTC) #2
xlai (Olivia)
lgtm.
3 years, 11 months ago (2017-01-12 17:50:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625873005/1
3 years, 11 months ago (2017-01-13 16:12:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/368688)
3 years, 11 months ago (2017-01-13 17:26:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625873005/20001
3 years, 11 months ago (2017-01-13 18:42:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/370842)
3 years, 11 months ago (2017-01-13 20:18:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625873005/40001
3 years, 11 months ago (2017-01-16 16:45:58 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 18:14:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/41d279a5476937a3981a8413be72...

Powered by Google App Engine
This is Rietveld 408576698