Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h

Issue 2625873005: Add an heuristic for promoting canvases to GPU acceleration (Closed)
Patch Set: webgl test fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
diff --git a/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h b/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
index b9c71588352c63cc2479a02940be70325495bccc..3fbcba25c6fc5aa2fd80d8728e68a2a9cc3e97b8 100644
--- a/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
+++ b/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
@@ -60,20 +60,11 @@ enum {
// lists. Rationale: The allocation of large textures for canvas
// tends to starve the compositor, and increase the probability of
// failure of subsequent allocations required for double buffering.
- PreferDisplayListOverGpuSizeThreshold = 4096 * 4096,
+ PreferDisplayListOverGpuSizeThreshold = 8096 * 4096,
// Disable Acceleration heuristic parameters
//===========================================
- GetImageDataForcesNoAcceleration = 1,
-
- // When a canvas is used as a source image, if its destination is
- // non-accelerated and the source canvas is accelerated, a readback
- // from the gpu is necessary. This option causes the source canvas to
- // switch to non-accelerated when this situation is encountered to
- // prevent future canvas-to-canvas draws from requiring a readback.
- DisableAccelerationToAvoidReadbacks = 1,
-
// When drawing very large images to canvases, there is a point where
// GPU acceleration becomes inefficient due to texture upload overhead,
// especially when the image is large enough that it is likely to
@@ -84,6 +75,27 @@ enum {
DrawImageTextureUploadSoftSizeLimitScaleThreshold = 4,
DrawImageTextureUploadHardSizeLimit = 8192 * 8192,
+ // GPU readback prevention heuristics
+ //====================================
+
+ GetImageDataForcesNoAcceleration = 1,
+
+ // When a canvas is used as a source image, if its destination is
+ // non-accelerated and the source canvas is accelerated, a readback
+ // from the gpu is necessary. This option causes the source canvas to
+ // switch to non-accelerated when this situation is encountered to
+ // prevent future canvas-to-canvas draws from requiring a readback.
+ DisableAccelerationToAvoidReadbacks = 0,
+
+ // See description of DisableAccelerationToAvoidReadbacks. This is the
+ // opposite strategy : accelerate the destination canvas. If both
+ // EnableAccelerationToAvoidReadbacks and
+ // DisableAccelerationToAvoidReadbacks are specified, we try to enable
+ // acceleration on the destination first. If that does not succeed,
+ // we disable acceleration on the source canvas. Either way, future
+ // readbacks are prevented.
+ EnableAccelerationToAvoidReadbacks = 1,
+
}; // enum
// Constants and Coefficients for 2D Canvas Dynamic Rendering Mode Switching

Powered by Google App Engine
This is Rietveld 408576698