Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Issue 2625873005: Add an heuristic for promoting canvases to GPU acceleration (Closed)
Patch Set: webgl test fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
index 37fc6a6f30a298f29cb07de2b81b48d8fce46342..080321b78f4b28f0a2fc8a443ff03f1690615ec6 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
@@ -90,7 +90,7 @@ class CanvasRenderingContext2DAutoRestoreSkCanvas {
explicit CanvasRenderingContext2DAutoRestoreSkCanvas(
CanvasRenderingContext2D* context)
: m_context(context), m_saveCount(0) {
- ASSERT(m_context);
+ DCHECK(m_context);
SkCanvas* c = m_context->drawingCanvas();
if (c) {
m_saveCount = c->getSaveCount();
@@ -195,7 +195,7 @@ void CanvasRenderingContext2D::didSetSurfaceSize() {
return;
// This code path is for restoring from an eviction
// Restoring from surface failure is handled internally
- ASSERT(m_contextLostMode != NotLostContext && !canvas()->hasImageBuffer());
+ DCHECK(m_contextLostMode != NotLostContext && !canvas()->hasImageBuffer());
if (canvas()->buffer()) {
if (contextLostRestoredEventsEnabled()) {
@@ -268,6 +268,10 @@ void CanvasRenderingContext2D::dispatchContextRestoredEvent(TimerBase*) {
}
}
+void CanvasRenderingContext2D::willDrawImage(CanvasImageSource* source) const {
+ canvas()->willDrawImageTo2DContext(source);
+}
+
ColorBehavior CanvasRenderingContext2D::drawImageColorBehavior() const {
return CanvasRenderingContext::colorBehaviorForMediaDrawnToCanvas();
}
@@ -452,7 +456,7 @@ void CanvasRenderingContext2D::setFont(const String& newFont) {
HashMap<String, Font>::iterator i =
m_fontsResolvedUsingCurrentStyle.find(newFont);
if (i != m_fontsResolvedUsingCurrentStyle.end()) {
- ASSERT(m_fontLRUList.contains(newFont));
+ DCHECK(m_fontLRUList.contains(newFont));
m_fontLRUList.remove(newFont);
m_fontLRUList.add(newFont);
modifiableState().setFont(
@@ -474,7 +478,7 @@ void CanvasRenderingContext2D::setFont(const String& newFont) {
canvas()->document().ensureStyleResolver().computeFont(fontStyle.get(),
*parsedStyle);
m_fontsResolvedUsingCurrentStyle.add(newFont, fontStyle->font());
- ASSERT(!m_fontLRUList.contains(newFont));
+ DCHECK(!m_fontLRUList.contains(newFont));
m_fontLRUList.add(newFont);
pruneLocalFontCache(canvasFontCache->hardMaxFonts()); // hard limit
schedulePruneLocalFontCacheIfNeeded(); // soft limit
@@ -682,7 +686,7 @@ static inline TextDirection toTextDirection(
case CanvasRenderingContext2DState::DirectionLTR:
return TextDirection::kLtr;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return TextDirection::kLtr;
}
@@ -829,9 +833,10 @@ void CanvasRenderingContext2D::drawTextInternal(
// anti-aliasing, which is expected when !creationAttributes().alpha(), so we
// need to fall out of display list mode when drawing text to an opaque
// canvas. crbug.com/583809
- if (!creationAttributes().alpha() && !isAccelerated())
+ if (!creationAttributes().alpha() && !isAccelerated()) {
canvas()->disableDeferral(
DisableDeferralReasonSubPixelTextAntiAliasingSupport);
+ }
const Font& font = accessFont();
font.getFontDescription().setSubpixelAscentDescent(true);
@@ -1003,7 +1008,7 @@ void CanvasRenderingContext2D::drawFocusIfNeededInternal(const Path& path,
bool CanvasRenderingContext2D::focusRingCallIsValid(const Path& path,
Element* element) {
- ASSERT(element);
+ DCHECK(element);
if (!state().isTransformInvertible())
return false;
if (path.isEmpty())
@@ -1090,9 +1095,10 @@ void CanvasRenderingContext2D::addHitRegion(const HitRegionOptions& options,
if (state().hasClip()) {
hitRegionPath.intersectPath(state().getCurrentClipPath());
- if (hitRegionPath.isEmpty())
+ if (hitRegionPath.isEmpty()) {
exceptionState.throwDOMException(NotSupportedError,
"The specified path has no pixels.");
+ }
}
if (!m_hitRegionManager)

Powered by Google App Engine
This is Rietveld 408576698