Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2625873003: DevTools: Move history handling into FilteredListWidget from the delegate (Closed)

Created:
3 years, 11 months ago by einbinder
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Move history handling into FilteredListWidget from the delegate BUG=none Review-Url: https://codereview.chromium.org/2625873003 Cr-Commit-Position: refs/heads/master@{#443375} Committed: https://chromium.googlesource.com/chromium/src/+/6840ab3edc1012310864ccbdb8ff0e25413020c3

Patch Set 1 #

Patch Set 2 : Fix test #

Messages

Total messages: 17 (9 generated)
einbinder
ptal
3 years, 11 months ago (2017-01-11 03:55:34 UTC) #2
dgozman
lgtm
3 years, 11 months ago (2017-01-11 18:29:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625873003/1
3 years, 11 months ago (2017-01-11 21:36:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/362187)
3 years, 11 months ago (2017-01-11 23:25:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625873003/20001
3 years, 11 months ago (2017-01-12 17:46:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/99293)
3 years, 11 months ago (2017-01-12 19:10:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625873003/20001
3 years, 11 months ago (2017-01-12 21:22:39 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 21:54:53 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6840ab3edc1012310864ccbdb8ff...

Powered by Google App Engine
This is Rietveld 408576698