Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

Issue 2625873003: DevTools: Move history handling into FilteredListWidget from the delegate (Closed)
Patch Set: Fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js b/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
index 357014a39b328bfba49735e9cd2d4b7fa7108e78..72be08cda8f1ee091f528e930025a7be419c0a0f 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
@@ -11,10 +11,9 @@ Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListDeleg
/**
* @param {!Sources.SourcesView} sourcesView
* @param {!Map.<!Workspace.UISourceCode, number>} defaultScores
- * @param {!Array<string>} history
*/
- constructor(sourcesView, defaultScores, history) {
- super(defaultScores, history);
+ constructor(sourcesView, defaultScores) {
+ super(defaultScores);
this._sourcesView = sourcesView;
this.populate();
}
@@ -26,10 +25,10 @@ Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListDeleg
* @param {!Array<string>} history
*/
static show(sourcesView, query, defaultScores, history) {
- var dialog = new Sources.OpenResourceDialog(sourcesView, defaultScores, history);
+ var dialog = new Sources.OpenResourceDialog(sourcesView, defaultScores);
if (InspectorFrontendHost.isUnderTest())
Sources.OpenResourceDialog._instanceForTest = dialog;
- var filteredItemSelectionDialog = new QuickOpen.FilteredListWidget(dialog);
+ var filteredItemSelectionDialog = new QuickOpen.FilteredListWidget(dialog, history);
filteredItemSelectionDialog.showAsDialog();
filteredItemSelectionDialog.setQuery(query);
}

Powered by Google App Engine
This is Rietveld 408576698