Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

Issue 2625873003: DevTools: Move history handling into FilteredListWidget from the delegate (Closed)
Patch Set: Fix test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
index 51279f2a8c4faf99bdd8ffb4f7bdcc39d4347719..c17bec987eae998334af9c39e8d82fa4d29c02f0 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
@@ -7,11 +7,6 @@ function test() {
var history = [];
var StubDelegate = class extends QuickOpen.FilteredListWidget.Delegate {
- constructor()
- {
- super(history);
- }
-
itemKeyAt(itemIndex) { return overridenInput[itemIndex]; }
itemScoreAt(itemIndex) { return 0; }
itemCount() { return overridenInput.length; }
@@ -31,7 +26,7 @@ function test() {
TestRunner.addResult("Input:" + JSON.stringify(input));
- var filteredSelectionDialog = new QuickOpen.FilteredListWidget(delegate);
+ var filteredSelectionDialog = new QuickOpen.FilteredListWidget(delegate, history);
filteredSelectionDialog.showAsDialog();
var promise = TestRunner.addSniffer(filteredSelectionDialog, "_itemsFilteredForTest").then(accept);
filteredSelectionDialog.setQuery(query);
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698