Re-reland: chromeos: Fix shelf appearing at login screen under mash

Re-reland: chromeos: Fix shelf appearing at login screen under mash

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Original-Original-Commit-Position: refs/heads/master@{#442484}
Review-Url: https://codereview.chromium.org/2625733003
Cr-Original-Commit-Position: refs/heads/master@{#443106}
Committed: https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4d01aa0569c1c
Review-Url: https://codereview.chromium.org/2625733003
Cr-Commit-Position: refs/heads/master@{#443174}
Committed: https://chromium.googlesource.com/chromium/src/+/e3d63f666dd906c320f67c7286f2d9a9316c2ef5

[James Cook, 2017-01-10 19:27:35]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 19:28:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 20:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 20:00:34]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-01-10 21:39:10]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 21:39:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 22:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 22:52:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2017-01-10 23:56:49]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 23:57:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-01-11 00:23:58]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 00:24:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-01-11 00:30:00]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 00:30:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-01-11 00:39:48]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org, xiyuan@chromium.org

[James Cook, 2017-01-11 00:39:50]

msw, xiyuan, please take another look.

Patchset #1 is the patch I reverted (the one you guys reviewed as
https://codereview.chromium.org/2573703003/ ) if you just want to see what
changed.

https://codereview.chromium.org/2625733003/diff/80001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2625733003/diff/80001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_widget.cc:406: return gfx::Rect();
This is the crash fix. It results in the window being animated to the
bottom-left corner of the screen (or a different corner, depending on the shelf
alignment setting).

https://codereview.chromium.org/2625733003/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/session/chrome_session_manager.cc (right):

https://codereview.chromium.org/2625733003/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/login/session/chrome_session_manager.cc:137: if
(!is_running_test) {
I took out the SessionControllerClient::FlushForTesting() in browser_tests
because I want tests to better simulate how ash starts up in production. This
also let me write a browser test for the crash.

https://codereview.chromium.org/2625733003/diff/80001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_browsertest.cc (right):

https://codereview.chromium.org/2625733003/diff/80001/chrome/browser/ui/brows...
chrome/browser/ui/browser_browsertest.cc:2666: // The behavior on OSX and Views
is incorrect in this edge case, but they are
msw, I ended up not deleting this code. Maybe it provides some value -- the
problem is an ordering issue with WebContents resized if a browser window is
resized mid-navigation. It looks like MacOS and non-MacOS make different choices
about when to commit things. Regardless, the problem on Chrome OS is related to
initial browser window sizes and doing a resize at the start of the test seems
to fix things.

[msw, 2017-01-11 00:54:55]

lgtm with nits and a q; nice testing, I hope this one sticks!

https://codereview.chromium.org/2625733003/diff/80001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2625733003/diff/80001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_widget.cc:404: // view is created.
nit: "In that case, return default empty bounds" (or similar).

https://codereview.chromium.org/2625733003/diff/80001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2625733003/diff/80001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:358: // Creates the ShelfView and populates it with icons.
optional nit: s/icons/items/ and remove the line above?

https://codereview.chromium.org/2625733003/diff/80001/chrome/browser/ui/ash/l...
File
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2625733003/diff/80001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc:399:
class ShelfAppBrowserTestNoDefaultBrowser : public ShelfAppBrowserTest {
Should this also call FlushForTesting?

[commit-bot: I haz the power, 2017-01-11 01:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:08:10]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-01-11 01:37:16]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 01:38:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 02:17:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 02:17:10]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-01-11 17:02:17]

lgtm++

[James Cook, 2017-01-11 17:03:49]

Thanks for the review.

https://codereview.chromium.org/2625733003/diff/80001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2625733003/diff/80001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_widget.cc:404: // view is created.
On 2017/01/11 00:54:54, msw wrote:
> nit: "In that case, return default empty bounds" (or similar).

Done.

https://codereview.chromium.org/2625733003/diff/80001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2625733003/diff/80001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:358: // Creates the ShelfView and populates it with icons.
On 2017/01/11 00:54:54, msw wrote:
> optional nit: s/icons/items/ and remove the line above?

Rewrote it.

https://codereview.chromium.org/2625733003/diff/80001/chrome/browser/ui/ash/l...
File
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2625733003/diff/80001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc:399:
class ShelfAppBrowserTestNoDefaultBrowser : public ShelfAppBrowserTest {
On 2017/01/11 00:54:54, msw wrote:
> Should this also call FlushForTesting?

I think this already does, because this is-a ShelfAppBrowserTest and that calls
FlushForTesting.

[James Cook, 2017-01-11 17:03:55]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-01-11 17:03:56]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2625733003/#ps100001
(title: "msw comments")

[commit-bot: I haz the power, 2017-01-11 17:04:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 17:11:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 17:11:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[James Cook, 2017-01-11 22:24:20]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2017-01-11 22:24:21]

sky, can I get OWNERS for
chrome/browser/session/session_restore_browsertest_chromeos.cc?

(Also, WDYT of adding a per-file chromeos owner for that test file?)

[James Cook, 2017-01-11 22:24:49]

Patchset #3 (id:40001) has been deleted

[James Cook, 2017-01-11 22:25:04]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 22:26:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 23:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:25:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2017-01-12 00:18:05]

On 2017/01/11 22:24:21, James Cook wrote:
> sky, can I get OWNERS for
> chrome/browser/session/session_restore_browsertest_chromeos.cc?
> 
> (Also, WDYT of adding a per-file chromeos owner for that test file?)

sky, please wait, I need to investigate mash_unittests failure, which will
probably result in a change to WmTestBase that you would be a good reviewer for.
:-)

[sky, 2017-01-12 00:19:16]

chrome/browser/session/session_restore_browsertest_chromeos.cc LGTM - I'm
definitely in favor of more owners where it makes sense.

[James Cook, 2017-01-12 00:37:34]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 00:38:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-01-12 00:39:53]

On 2017/01/12 00:19:16, sky wrote:
> chrome/browser/session/session_restore_browsertest_chromeos.cc LGTM - I'm
> definitely in favor of more owners where it makes sense.

sky, it turns out the mash_unittests failure was trivial to fix - I just had to
move some user session setup code from AshTestImplMus to WmTestBase. You're
welcome to look at ash/mus/test/ but I don't think it needs re-review, I'm going
to land this.

[James Cook, 2017-01-12 00:40:00]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2017-01-12 00:40:26]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-01-12 00:40:26]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
xiyuan@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2625733003/#ps140001
(title: "fix mash_unittests")

[commit-bot: I haz the power, 2017-01-12 00:41:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 01:23:52]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484181626048180,
"parent_rev": "f595ad7b407516b53f00b1766a469f59b32c9204", "commit_rev":
"75298de72cf7c25e137c3c5e63e4d01aa0569c1c"}

[commit-bot: I haz the power, 2017-01-12 01:24:22]

Description was changed from

==========
Reland: chromeos: Fix shelf appearing at login screen under mash

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Commit-Position: refs/heads/master@{#442484}
==========

to

==========
Reland: chromeos: Fix shelf appearing at login screen under mash

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Original-Commit-Position: refs/heads/master@{#442484}
Review-Url: https://codereview.chromium.org/2625733003
Cr-Commit-Position: refs/heads/master@{#443106}
Committed:
https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4...
==========

[commit-bot: I haz the power, 2017-01-12 01:24:24]

Committed patchset #7 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4...

[ynovikov, 2017-01-12 02:24:11]

On 2017/01/12 01:24:24, commit-bot: I haz the power wrote:
> Committed patchset #7 (id:140001) as
>
https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4...

This conflicts with https://codereview.chromium.org/2628973002

[Timothy Loh, 2017-01-12 03:24:16]

A revert of this CL (patchset #7 id:140001) has been created in
https://codereview.chromium.org/2628933003/ by timloh@chromium.org.

The reason for reverting is: compile broken and reverting
https://codereview.chromium.org/2628973002 didn't seem to fix it..

[James Cook, 2017-01-12 06:38:01]

sky has relanded https://codereview.chromium.org/2628973002

I've rebased on top of that and resolved the conflict. (I deleted the ShowShelf
function in my CL, he moved it from one file to another so it "came back".)

I'm going to reland.

[James Cook, 2017-01-12 06:38:43]

Description was changed from

==========
Reland: chromeos: Fix shelf appearing at login screen under mash

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Original-Commit-Position: refs/heads/master@{#442484}
Review-Url: https://codereview.chromium.org/2625733003
Cr-Commit-Position: refs/heads/master@{#443106}
Committed:
https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4...
==========

to

==========
Re-reland: chromeos: Fix shelf appearing at login screen under mash

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Original-Commit-Position: refs/heads/master@{#442484}
Review-Url: https://codereview.chromium.org/2625733003
Cr-Commit-Position: refs/heads/master@{#443106}
Committed:
https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4...
==========

[James Cook, 2017-01-12 06:38:53]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-01-12 06:38:53]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
sky@chromium.org, xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2625733003/#ps160001
(title: "rebase, fix conflict with sky")

[commit-bot: I haz the power, 2017-01-12 06:39:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 07:12:45]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1484203133298910,
"parent_rev": "64efa56e5bb67106cea0eb4033b866d9217d8324", "commit_rev":
"e3d63f666dd906c320f67c7286f2d9a9316c2ef5"}

[commit-bot: I haz the power, 2017-01-12 07:13:20]

Description was changed from

==========
Re-reland: chromeos: Fix shelf appearing at login screen under mash

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Original-Commit-Position: refs/heads/master@{#442484}
Review-Url: https://codereview.chromium.org/2625733003
Cr-Commit-Position: refs/heads/master@{#443106}
Committed:
https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4...
==========

to

==========
Re-reland: chromeos: Fix shelf appearing at login screen under mash

The reland adds a fix for a crash in window animation code when restoring
a session that has a minimized window. The animation tries to compute a
shelf item position before the shelf is initialized. The animation is not
visible to the user. Returning an empty rect results in a default target
position, which is fine in this case.

Added guards for access to ShelfView before shelf is initialized.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

Reverted:

Review-Url: https://codereview.chromium.org/2619943002
Cr-Original-Original-Commit-Position: refs/heads/master@{#442484}
Review-Url: https://codereview.chromium.org/2625733003
Cr-Original-Commit-Position: refs/heads/master@{#443106}
Committed:
https://chromium.googlesource.com/chromium/src/+/75298de72cf7c25e137c3c5e63e4...
Review-Url: https://codereview.chromium.org/2625733003
Cr-Commit-Position: refs/heads/master@{#443174}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3d63f666dd906c320f67c7286f2...
==========

[commit-bot: I haz the power, 2017-01-12 07:13:22]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/e3d63f666dd906c320f67c7286f2...