Revert "chromeos: Fix shelf appearing at login screen under mash"

Revert "chromeos: Fix shelf appearing at login screen under mash"

That CL causes browser crashes on login when the browser is restoring a
minimized window as part of session restore. The crashes occur because the
shelf view is created asynchronously in response to a mojo message, but
the window restore is synchronous at startup.  I will investigate more and
reland.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021, 679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

TBR=msw@chromium.org,xiyuan@chromium.org for revert

Review-Url: https://codereview.chromium.org/2619943002
Cr-Commit-Position: refs/heads/master@{#442484}
Committed: https://chromium.googlesource.com/chromium/src/+/e8604fbd50fd6e6b3e69f51fd79473df92276f96

[James Cook, 2017-01-10 00:53:52]

Description was changed from

==========
Revert "chromeos: Fix shelf appearing at login screen under mash"

That CL causes browser crashes on login when the browser is restoring a
minimized window as part of session restore. The crashes occur because the
shelf view is created asynchronously in response to a mojo message, but
the window restore is synchronous at startup.  I will investigate more and
reland.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021,679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}
==========

to

==========
Revert "chromeos: Fix shelf appearing at login screen under mash"

That CL causes browser crashes on login when the browser is restoring a
minimized window as part of session restore. The crashes occur because the
shelf view is created asynchronously in response to a mojo message, but
the window restore is synchronous at startup.  I will investigate more and
reland.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021,679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

TBR=msw@chromium.org,xiyuan@chromium.org for revert
==========

[James Cook, 2017-01-10 00:57:02]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org, xiyuan@chromium.org

[James Cook, 2017-01-10 00:57:03]

TBR msw and xiyuan for revert.

[James Cook, 2017-01-10 00:57:08]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:58:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-01-10 01:12:07]

bummer; lgtm

[commit-bot: I haz the power, 2017-01-10 02:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 02:59:49]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[James Cook, 2017-01-10 03:27:33]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:28:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 04:54:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484018853833430, "parent_rev":
"eaf9f345dc3d9d8f34d63e72cd6b9b0515c96e0c", "commit_rev":
"e8604fbd50fd6e6b3e69f51fd79473df92276f96"}

[commit-bot: I haz the power, 2017-01-10 04:55:22]

Description was changed from

==========
Revert "chromeos: Fix shelf appearing at login screen under mash"

That CL causes browser crashes on login when the browser is restoring a
minimized window as part of session restore. The crashes occur because the
shelf view is created asynchronously in response to a mojo message, but
the window restore is synchronous at startup.  I will investigate more and
reland.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021,679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

TBR=msw@chromium.org,xiyuan@chromium.org for revert
==========

to

==========
Revert "chromeos: Fix shelf appearing at login screen under mash"

That CL causes browser crashes on login when the browser is restoring a
minimized window as part of session restore. The crashes occur because the
shelf view is created asynchronously in response to a mojo message, but
the window restore is synchronous at startup.  I will investigate more and
reland.

Original CL description:

Previously chrome --mash would always create the shelf on startup, even at
the login screen. Now it waits until login is complete, like classic ash.

Ash watches for SessionState::ACTIVE via a SessionStateObserver to create the
shelf, rather than NOTIFICATION_LOGIN_USER_PROFILE_PREPARED. For most login
flows this doesn't matter, but for supervised user creation it means that the
shelf is not created until the flow is completed. This is an improvement
because in the old code the shelf would be created too early and had to be
explicitly hidden.

Always create a SessionControllerClient in chrome, even in classic ash. This
allows classic ash to use the mojo pathway via ash::SessionController.

Remove WmShell::ShowShelf(), which was introduced in crrev.com/10693003 to
delay showing the shelf until post-login OOBE (like avatar picture select)
was complete. It does not seem to be needed anymore, either in production or
in tests.

Change AshTestImplMus to simulate a user logging in which is required to
create the shelf on the primary display and also to have a non-zero user
count to create the shelf on additional displays.

Remove some unnecessary OS_CHROMEOS ifdefs in //c/b/ui/ash.

BUG=666021,679513
TEST=ash_unittests and chrome browser_tests

Committed: https://crrev.com/7f99e933e595824281102ff6737075dccbbc4d5c
Cr-Commit-Position: refs/heads/master@{#439845}

TBR=msw@chromium.org,xiyuan@chromium.org for revert

Review-Url: https://codereview.chromium.org/2619943002
Cr-Commit-Position: refs/heads/master@{#442484}
Committed:
https://chromium.googlesource.com/chromium/src/+/e8604fbd50fd6e6b3e69f51fd794...
==========

[commit-bot: I haz the power, 2017-01-10 04:55:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8604fbd50fd6e6b3e69f51fd794...