Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2625653002: [telemetry] Fix bug in form_based_credentials_backend (Closed)

Created:
3 years, 11 months ago by perezju
Modified:
3 years, 11 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[telemetry] Fix bug in form_based_credentials_backend During refactor in CL: https://codereview.chromium.org/2615943003 a bug was introduced in form_based_credentials_backend module that prevented it from finding the login form by it's CSS id. TBR=nednguyen@google.com BUG=chromium:679518 Review-Url: https://codereview.chromium.org/2625653002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f1ec9eb8cd1564cc3b2e4cc06720d84fe46f9c91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M telemetry/telemetry/internal/backends/form_based_credentials_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625653002/1
3 years, 11 months ago (2017-01-10 11:30:12 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 11:53:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698