Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: telemetry/telemetry/internal/backends/form_based_credentials_backend.py

Issue 2625653002: [telemetry] Fix bug in form_based_credentials_backend (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/form_based_credentials_backend.py
diff --git a/telemetry/telemetry/internal/backends/form_based_credentials_backend.py b/telemetry/telemetry/internal/backends/form_based_credentials_backend.py
index aaa56b40aa43224569d0b8d919e8bfeaaa54b82b..bebf3f13f45a5e3190d496d7ec331a8989130c69 100644
--- a/telemetry/telemetry/internal/backends/form_based_credentials_backend.py
+++ b/telemetry/telemetry/internal/backends/form_based_credentials_backend.py
@@ -58,7 +58,7 @@ class FormBasedCredentialsBackend(object):
"""Waits until it can detect either the login form, or already logged in."""
action_runner.WaitForJavaScriptCondition(
'(document.querySelector({{ form_id }}) !== null) || ({{ @code }})',
- form_id=self.login_form_id, code=self.logged_in_javascript,
+ form_id='#' + self.login_form_id, code=self.logged_in_javascript,
timeout_in_seconds=60)
def _SubmitLoginFormAndWait(self, action_runner, tab, username, password):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698